Add cropped-then-expanded test cases to blur_image_filter tests.

Add cropped-then-expanded test cases to blur_image_filter tests.

These are benches similar to the imagefilterscropexpand GM: an
input filter is cropped to a smaller size, then the blur is re-expanded
out to a larger size.

BUG=skbug:4502
Committed: https://skia.googlesource.com/skia/+/a8bd38e1787417cb472ee5381bd9ce6e126afb41

[Stephen White, 2015-10-30 15:23:03]

Description was changed from

==========
Add cropped-then-expanded test cases to blur_image_filter tests.

These are benches similar to the imagefilterscropexpand GM: an
input filter is cropped to a smaller size, then the blur is re-expanded
out to a larger size.

BUG=skbug:4502
==========

to

==========
Add cropped-then-expanded test cases to blur_image_filter tests.

These are benches similar to the imagefilterscropexpand GM: an
input filter is cropped to a smaller size, then the blur is re-expanded
out to a larger size.

BUG=skbug:4502
==========

[Stephen White, 2015-10-30 15:23:03]

senorblanco@chromium.org changed reviewers:
+ reed@google.com, robertphillips@google.com

[Stephen White, 2015-10-30 15:23:43]

reed@ | robertphillips@: PTAL.

This exercises the improvement in https://codereview.chromium.org/1415653003/.

[robertphillips, 2015-10-30 17:09:14]

lgtm + dox requests

https://codereview.chromium.org/1412373004/diff/20001/bench/BlurImageFilterBe...
File bench/BlurImageFilterBench.cpp (right):

https://codereview.chromium.org/1412373004/diff/20001/bench/BlurImageFilterBe...
bench/BlurImageFilterBench.cpp:25: 
// When 'cropped' is set we apply a cropRect to the blurImageFilter. The crop
rect is an inset of the source's natural dimensions.
// This is intended to exercise ...

// When 'expanded' is set we apply a cropRect to the input of the
blurImageFilter (via a noOp offsetImageFilter).
// The crop rect in this case is an inset of the source's natural dimensions. An
additional crop rect is applied to the blurImageFilter that is just the natural
dimensions of the source (not inset).
// This is intended to exercise ...

?

https://codereview.chromium.org/1412373004/diff/20001/bench/BlurImageFilterBe...
bench/BlurImageFilterBench.cpp:29: bool expanded) :
knock this into the canonical "\n:X\n,Y {" formatting ?

https://codereview.chromium.org/1412373004/diff/20001/bench/BlurImageFilterBe...
bench/BlurImageFilterBench.cpp:36: SkScalarToFloat(sigmaX),
SkScalarToFloat(sigmaY));
SkASSERT(!fIsExpanded || fIsCropped); // never want expansion w/o cropping

?

[Stephen White, 2015-10-30 20:05:47]

https://codereview.chromium.org/1412373004/diff/20001/bench/BlurImageFilterBe...
File bench/BlurImageFilterBench.cpp (right):

https://codereview.chromium.org/1412373004/diff/20001/bench/BlurImageFilterBe...
bench/BlurImageFilterBench.cpp:25: 
On 2015/10/30 17:09:14, robertphillips wrote:
> // When 'cropped' is set we apply a cropRect to the blurImageFilter. The crop
> rect is an inset of the source's natural dimensions.
> // This is intended to exercise ...
> 
> // When 'expanded' is set we apply a cropRect to the input of the
> blurImageFilter (via a noOp offsetImageFilter).
> // The crop rect in this case is an inset of the source's natural dimensions.
An
> additional crop rect is applied to the blurImageFilter that is just the
natural
> dimensions of the source (not inset).
> // This is intended to exercise ...
> 
> ?

Done.

https://codereview.chromium.org/1412373004/diff/20001/bench/BlurImageFilterBe...
bench/BlurImageFilterBench.cpp:29: bool expanded) :
On 2015/10/30 17:09:14, robertphillips wrote:
> knock this into the canonical "\n:X\n,Y {" formatting ?

Done.

https://codereview.chromium.org/1412373004/diff/20001/bench/BlurImageFilterBe...
bench/BlurImageFilterBench.cpp:36: SkScalarToFloat(sigmaX),
SkScalarToFloat(sigmaY));
On 2015/10/30 17:09:14, robertphillips wrote:
> SkASSERT(!fIsExpanded || fIsCropped); // never want expansion w/o cropping
> 
> ?

Done.

[Stephen White, 2015-10-30 20:06:22]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2015-10-30 20:06:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1412373004/#ps40001
(title: "Fixes per review comments")

[commit-bot: I haz the power, 2015-10-30 20:06:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412373004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412373004/40001

[commit-bot: I haz the power, 2015-10-30 20:17:24]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a8bd38e1787417cb472ee5381bd9ce6e126afb41