Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1412343009: [Interpreter] Skip some more tests on Arm64 for Ignition. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Skip some more tests on Arm64 for Ignition. Skips some more tests which started failing after https://codereview.chromium.org/1414183006 landed. BUG=v8:4280 LOG=N NOTRY=True Committed: https://crrev.com/1820acb9c959e715e8bfdf39baa4e927cacd4d23 Cr-Commit-Position: refs/heads/master@{#31919}

Patch Set 1 #

Patch Set 2 : Add test262 failures #

Patch Set 3 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +8 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
rmcilroy
PTAL, thanks.
5 years, 1 month ago (2015-11-10 14:38:54 UTC) #2
Michael Achenbach
On 2015/11/10 14:38:54, rmcilroy wrote: > PTAL, thanks. lgtm. Did you also check the stdout ...
5 years, 1 month ago (2015-11-10 14:58:55 UTC) #3
Michael Achenbach
FYI: on debug fail some more tests - also test262: https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/4995
5 years, 1 month ago (2015-11-10 15:00:17 UTC) #4
rmcilroy
Missed the test262 test - added them now. The other mjsunit test failures were already ...
5 years, 1 month ago (2015-11-10 15:17:09 UTC) #5
rmcilroy
Missed the test262 test - added them now. The other mjsunit test failures were already ...
5 years, 1 month ago (2015-11-10 15:17:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412343009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412343009/40001
5 years, 1 month ago (2015-11-10 15:20:17 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-10 15:21:36 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 15:22:04 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1820acb9c959e715e8bfdf39baa4e927cacd4d23
Cr-Commit-Position: refs/heads/master@{#31919}

Powered by Google App Engine
This is Rietveld 408576698