Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1412343008: Factor out the string lookup code from registry_controlled_domains (Closed)

Created:
5 years, 1 month ago by Adam Rice
Modified:
4 years, 9 months ago
Reviewers:
eroman, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor out the string lookup code from registry_controlled_domains The string lookup code used by registry_controlled_domains is generally useful as it provides for efficient lookup of strings in a set with no runtime initialisation overhead. Factor it out into a public LookupStringInFixedSet function and add unit tests. BUG=348877 TEST=net_unittests Committed: https://crrev.com/3f054c2a5289d812e69f56ec613cc3f2179c50d0 Cr-Commit-Position: refs/heads/master@{#359506}

Patch Set 1 #

Patch Set 2 : Add missing unit test. #

Total comments: 5

Patch Set 3 : Change constants to an enum. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -1811 lines) Patch
A + net/base/lookup_string_in_fixed_set.h View 1 2 3 1 chunk +27 lines, -36 lines 0 comments Download
A + net/base/lookup_string_in_fixed_set.cc View 7 chunks +22 lines, -265 lines 0 comments Download
A + net/base/lookup_string_in_fixed_set_unittest.cc View 1 2 3 1 chunk +138 lines, -107 lines 0 comments Download
M net/base/registry_controlled_domains/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/base/registry_controlled_domains/registry_controlled_domain.cc View 3 chunks +8 lines, -141 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M net/net.gypi View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A + net/tools/dafsa/PRESUBMIT.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + net/tools/dafsa/make_dafsa.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/tools/dafsa/make_dafsa_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/tools/tld_cleanup/PRESUBMIT.py View 1 chunk +0 lines, -32 lines 0 comments Download
D net/tools/tld_cleanup/make_dafsa.py View 1 chunk +0 lines, -469 lines 0 comments Download
D net/tools/tld_cleanup/make_dafsa_unittest.py View 1 chunk +0 lines, -757 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (8 generated)
Adam Rice
Refactoring of LookupString() code split out from https://codereview.chromium.org/1303973009/ Please review this instead of that.
5 years, 1 month ago (2015-11-09 11:02:22 UTC) #2
eroman
Thanks for splitting this out to a separate CL! I will review this later today ...
5 years, 1 month ago (2015-11-09 19:32:58 UTC) #3
eroman
https://codereview.chromium.org/1412343008/diff/20001/net/base/lookup_string_in_fixed_set.h File net/base/lookup_string_in_fixed_set.h (right): https://codereview.chromium.org/1412343008/diff/20001/net/base/lookup_string_in_fixed_set.h#newcode14 net/base/lookup_string_in_fixed_set.h:14: const int kDafsaNotFound = -1; // key is not ...
5 years, 1 month ago (2015-11-10 02:47:21 UTC) #4
Adam Rice
https://codereview.chromium.org/1412343008/diff/20001/net/base/lookup_string_in_fixed_set.h File net/base/lookup_string_in_fixed_set.h (right): https://codereview.chromium.org/1412343008/diff/20001/net/base/lookup_string_in_fixed_set.h#newcode14 net/base/lookup_string_in_fixed_set.h:14: const int kDafsaNotFound = -1; // key is not ...
5 years, 1 month ago (2015-11-10 03:20:51 UTC) #5
eroman
lgtm
5 years, 1 month ago (2015-11-13 00:00:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412343008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412343008/40001
5 years, 1 month ago (2015-11-13 00:12:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/122604) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-13 00:15:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412343008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412343008/60001
5 years, 1 month ago (2015-11-13 01:44:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/140131) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-13 01:52:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412343008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412343008/60001
5 years, 1 month ago (2015-11-13 06:18:06 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-13 06:48:30 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3f054c2a5289d812e69f56ec613cc3f2179c50d0 Cr-Commit-Position: refs/heads/master@{#359506}
5 years, 1 month ago (2015-11-13 06:49:06 UTC) #19
Ryan Sleevi
When this experiment is over, will you remove this refactoring and place the code back ...
5 years, 1 month ago (2015-11-13 08:42:16 UTC) #21
Adam Rice
On 2015/11/13 08:42:16, Ryan Sleevi (OOO. no rvws plz) wrote: > When this experiment is ...
5 years, 1 month ago (2015-11-13 17:03:24 UTC) #22
Ryan Sleevi
On 2015/11/13 17:03:24, Adam Rice wrote: > My belief was that since it is generally ...
5 years, 1 month ago (2015-11-13 17:24:59 UTC) #23
Ryan Sleevi
On 2015/11/13 17:24:59, Ryan Sleevi (OOO. no rvws plz) wrote: > But stepping back a ...
5 years, 1 month ago (2015-11-18 16:05:28 UTC) #24
Adam Rice
On 2015/11/18 16:05:28, Ryan Sleevi (OOO. no rvws plz) wrote: > Ping on this. I'm ...
5 years, 1 month ago (2015-11-18 16:22:21 UTC) #25
Ryan Sleevi
On 2015/11/18 16:22:21, Adam Rice wrote: > On 2015/11/18 16:05:28, Ryan Sleevi (OOO. no rvws ...
4 years, 11 months ago (2016-01-26 00:01:13 UTC) #26
Adam Rice
On 2016/01/26 00:01:13, Ryan Sleevi wrote: > Is this good to be removed now? There's ...
4 years, 11 months ago (2016-01-26 00:28:58 UTC) #27
Ryan Sleevi
4 years, 9 months ago (2016-03-01 16:10:52 UTC) #28
Message was sent while issue was closed.
On 2016/01/26 00:28:58, Adam Rice wrote:
> On 2016/01/26 00:01:13, Ryan Sleevi wrote:
> > Is this good to be removed now?
> 
> There's another experiment I want to run on M50 in February, so if I could
have
> a stay of execution for 3 weeks or so I would really appreciate it.

OK, I need to fix bugs, so I'm going to be reverting this code.

Powered by Google App Engine
This is Rietveld 408576698