Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1412343002: Fix calls to pthread_join (Closed)

Created:
5 years, 2 months ago by zra
Modified:
5 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M runtime/vm/os_thread_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
We can land this after verifying locally.
5 years, 2 months ago (2015-10-19 21:31:10 UTC) #2
Cutch
LGTM I've reproduced locally the thread stack mappings grew from 8 to 33 over an ...
5 years, 2 months ago (2015-10-19 22:02:40 UTC) #3
zra
5 years, 2 months ago (2015-10-19 22:10:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc0a9c3e7eb32588c219f7f16a1a806e88a397d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698