Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1412333005:
Add v8_external_startup_data GN rule (Closed)
DescriptionAdd v8_external_startup_data GN rule
The new GN rule will enable removal of code which copies natives_blob.bin and
snapshot_blob.bin in Android GN code (for instance "copy_content_shell_assets").
BUG=547162
LOG=Y
Committed: https://crrev.com/fa4bd0b9ab6f7319cee05a53104c4df98f4b7a86
Cr-Commit-Position: refs/heads/master@{#31835}
Patch Set 1 : #Messages
Total messages: 20 (9 generated)
Patchset #1 (id:1) has been deleted
Description was changed from
==========
Add v8_external_startup_data GN rule
The new GN rule will enable removal of code which copies natives_blob.bin and
snapshot_blob.bin in Android GN code (for instance "copy_content_shell_assets").
BUG=547162
Version 4.8.193
Performance and stability improvements on all platforms.
Cr-Commit-Position: refs/heads/4.8.193@{#1}
Cr-Branched-From:
44b520f57ffc1ec790de271ee92d514f40856a14-refs/heads/master@{#31698}
==========
to
==========
Add v8_external_startup_data GN rule
The new GN rule will enable removal of code which copies natives_blob.bin and
snapshot_blob.bin in Android GN code (for instance "copy_content_shell_assets").
BUG=547162
==========
Patchset #1 (id:20001) has been deleted
pkotwicz@chromium.org changed reviewers: + agrieve@chromium.org
agrieve@ can you take a look before I send the CL over to OWNERS
On 2015/11/03 18:13:12, pkotwicz wrote: > agrieve@ can you take a look before I send the CL over to OWNERS lgtm, but I think it might make more sense in //gin since //gin/v8_initializer.cc is the place that uses the files and requires them to be uncompressed as assets.
I like having this in v8 because the bin files are generated by //v8:natives_blob and //v8:v8_external_snapshot jochen@ can you please take a look? Also do you think that the correct place for this code is //v8/ or //gin/ ?
pkotwicz@chromium.org changed reviewers: + jochen@chromium.org
I like having this in v8 because the bin files are generated by //v8:natives_blob and //v8:v8_external_snapshot jochen@ can you please take a look? Also do you think that the correct place for this code is //v8/ or //gin/ ? https://codereview.chromium.org/1421473010/ uses the changes introduced by this CL
I like having this in v8 because the bin files are generated by //v8:natives_blob and //v8:v8_external_snapshot jochen@ can you please take a look? Also do you think that the correct place for this code is //v8/ or //gin/ ? I have only tested this CL against the v8 trybots. (I have not tried building Chrome with the master version of v8 or building v8 without Chrome) Is there more extensive testing that I should do? https://codereview.chromium.org/1421473010/ uses the changes introduced by this CL
lgtm
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412333005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412333005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7485)
Description was changed from ========== Add v8_external_startup_data GN rule The new GN rule will enable removal of code which copies natives_blob.bin and snapshot_blob.bin in Android GN code (for instance "copy_content_shell_assets"). BUG=547162 ========== to ========== Add v8_external_startup_data GN rule The new GN rule will enable removal of code which copies natives_blob.bin and snapshot_blob.bin in Android GN code (for instance "copy_content_shell_assets"). BUG=547162 LOG=Y ==========
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412333005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412333005/40001
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fa4bd0b9ab6f7319cee05a53104c4df98f4b7a86 Cr-Commit-Position: refs/heads/master@{#31835} |
