chrome/telemetry_perf_unittests.isolate - Issue 1412333004: Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and trybot with swarming

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/telemetry_perf_unittests.isolate

Issue 1412333004: Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and trybot with swarming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix + swarming Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'includes': [

	6 '../tools/perf/perf.isolate',

	7 ],

	8 'conditions': [

	9 ['OS=="mac" or OS=="win"', {

	10 'variables': {

	11 'files': [

	12 # Other dependencies of the tests and their harness.

	13 '../testing/test_env.py',

	14 '../testing/xvfb.py',
	M-A Ruel 2015/10/30 12:36:03 xvfb is never needed on non linux OSes. xvfb is never needed on non linux OSes. nednguyen 2015/10/30 12:37:43 We need this to resolve the "import xvfb" on other Show quoted text On 2015/10/30 12:36:03, M-A Ruel wrote: > xvfb is never needed on non linux OSes. We need this to resolve the "import xvfb" on other OSes. M-A Ruel 2015/10/30 12:41:18 I see, I wish the import would have been condition Show quoted text On 2015/10/30 12:37:43, nednguyen wrote: > On 2015/10/30 12:36:03, M-A Ruel wrote: > > xvfb is never needed on non linux OSes. > > We need this to resolve the "import xvfb" on other OSes. I see, I wish the import would have been conditional. Oh well.
	15 '../testing/scripts/common.py',

	16 '../testing/scripts/run_telemetry_as_googletest.py',

	17 ],

	18 'command': [

	19 '../testing/scripts/run_telemetry_as_googletest.py',

	20 '../tools/perf/run_tests',

	21 '-v',

	22 ],

	23 },

	24 }],

	25 ]

	26 }

OLD	NEW

« no previous file with comments | « chrome/chrome_tests.gypi ('k') | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »