Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1412313006: Remove remoting::protocol::Transport interface. (Closed)

Created:
5 years, 1 month ago by Sergey Ulanov
Modified:
5 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@transport_session.h
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remoting::protocol::Transport interface. Moved and renamed LibjingleTransport in libjingle_transport_factory.cc to IceTransportChannel in ice_transport_channel.cc. Removed LibjingleTransportFactory class and moved all code to IceTransportFactory. BUG=547158 Committed: https://crrev.com/a77490672cf7691bedcc29e2adeeb8645cbc5f16 Cr-Commit-Position: refs/heads/master@{#356659}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -848 lines) Patch
M remoting/protocol/channel_socket_adapter.h View 1 1 chunk +1 line, -1 line 0 comments Download
A remoting/protocol/ice_transport_channel.h View 1 chunk +138 lines, -0 lines 0 comments Download
A + remoting/protocol/ice_transport_channel.cc View 15 chunks +46 lines, -201 lines 0 comments Download
M remoting/protocol/ice_transport_factory.h View 1 3 chunks +19 lines, -4 lines 0 comments Download
M remoting/protocol/ice_transport_factory.cc View 1 chunk +69 lines, -12 lines 0 comments Download
M remoting/protocol/ice_transport_session.h View 1 6 chunks +28 lines, -13 lines 0 comments Download
M remoting/protocol/ice_transport_session.cc View 5 chunks +42 lines, -16 lines 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D remoting/protocol/libjingle_transport_factory.h View 1 chunk +0 lines, -69 lines 0 comments Download
D remoting/protocol/libjingle_transport_factory.cc View 1 chunk +0 lines, -452 lines 0 comments Download
M remoting/protocol/transport.h View 2 chunks +0 lines, -70 lines 0 comments Download
M remoting/remoting_srcs.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/test/test_chromoting_client_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
Sergey Ulanov
5 years, 1 month ago (2015-10-28 00:20:31 UTC) #2
Jamie
Is this another refactor CL that should not change behaviour? LGTM if so, otherwise please ...
5 years, 1 month ago (2015-10-28 00:50:54 UTC) #3
Sergey Ulanov
Correct, there are no functional changes here, just finishing refactoring started in the previous CL.
5 years, 1 month ago (2015-10-28 17:48:19 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/1412313006/diff/1/remoting/protocol/ice_transport_factory.h File remoting/protocol/ice_transport_factory.h (right): https://codereview.chromium.org/1412313006/diff/1/remoting/protocol/ice_transport_factory.h#newcode25 remoting/protocol/ice_transport_factory.h:25: class LibjingleTransportFactory; On 2015/10/28 00:50:54, Jamie wrote: > Remove ...
5 years, 1 month ago (2015-10-28 20:16:16 UTC) #6
Jamie
lgtm
5 years, 1 month ago (2015-10-28 20:26:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412313006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412313006/40001
5 years, 1 month ago (2015-10-28 21:11:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-10-28 21:57:52 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 21:58:59 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a77490672cf7691bedcc29e2adeeb8645cbc5f16
Cr-Commit-Position: refs/heads/master@{#356659}

Powered by Google App Engine
This is Rietveld 408576698