Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 14123005: Remove operator function. (Closed)

Created:
7 years, 8 months ago by Seigo Nonaka
Modified:
7 years, 8 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove operator function. To making InputMethodDescriptor simple, let me remove operators. Also remove operator related tests because operator had been used only in tests. BUG=None TEST=ran all unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195408

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -68 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 4 chunks +17 lines, -14 lines 0 comments Download
M chromeos/chromeos.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/ime/input_method_descriptor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/ime/input_method_descriptor.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D chromeos/ime/input_method_descriptor_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Seigo Nonaka
7 years, 8 months ago (2013-04-18 18:25:44 UTC) #1
satorux1
LGTM with a nit https://codereview.chromium.org/14123005/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc File chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc (right): https://codereview.chromium.org/14123005/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc#newcode34 chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc:34: bool IsContained(const InputMethodDescriptors& descriptors, function ...
7 years, 8 months ago (2013-04-19 03:54:17 UTC) #2
Seigo Nonaka
Thank you for your review! https://codereview.chromium.org/14123005/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc File chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc (right): https://codereview.chromium.org/14123005/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc#newcode34 chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc:34: bool IsContained(const InputMethodDescriptors& descriptors, ...
7 years, 8 months ago (2013-04-20 04:50:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14123005/5001
7 years, 8 months ago (2013-04-20 04:50:46 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 05:01:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14123005/5001
7 years, 8 months ago (2013-04-20 06:52:08 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 06:58:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14123005/5001
7 years, 8 months ago (2013-04-21 04:35:12 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-21 04:41:15 UTC) #9
Seigo Nonaka
7 years, 8 months ago (2013-04-21 06:32:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r195408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698