Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(79)

Issue 1412293005: Defer to engine for option-aware context config. (Closed)

Created:
3 years, 11 months ago by pquitslund
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/analyzer_cli.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Defer to engine for option-aware context config. * Leans on new `configureContext` function to pick up latest options support from engine. * Adds options integration tests. * Cleans up `Driver` test output. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/analyzer_cli/commit/c93a3d2d1c7715a6c7a067ebdbc9ba716b865226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -30 lines) Patch
M lib/src/driver.dart View 3 chunks +8 lines, -2 lines 0 comments Download
M lib/src/options.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/data/empty_options.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A test/data/no_lints_project/.analysis_options View 1 chunk +1 line, -0 lines 0 comments Download
A + test/data/no_lints_project/test_file.dart View 1 chunk +1 line, -1 line 0 comments Download
A test/data/options_tests_project/.analysis_options View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/data/options_tests_project/test_file.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/driver_test.dart View 9 chunks +100 lines, -23 lines 0 comments Download
M test/strong_mode_test.dart View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
3 years, 11 months ago (2015-10-29 21:21:34 UTC) #2
Brian Wilkerson
LGTM
3 years, 11 months ago (2015-10-29 22:00:47 UTC) #3
pquitslund
3 years, 11 months ago (2015-10-29 22:01:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c93a3d2d1c7715a6c7a067ebdbc9ba716b865226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698