Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: third_party/android_platform/development/scripts/stack

Issue 1412293002: Android: Make stack tool work for GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments 2 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/android_platform/development/scripts/symbol.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/android_platform/development/scripts/stack
diff --git a/third_party/android_platform/development/scripts/stack b/third_party/android_platform/development/scripts/stack
index c5a56c61e031fd1ba226ea958e3ce20cc9d9fba1..6c60c177e02ef1c670ff7549a3b6d3340c69bc0a 100755
--- a/third_party/android_platform/development/scripts/stack
+++ b/third_party/android_platform/development/scripts/stack
@@ -138,7 +138,7 @@ def main(argv):
elif option == "--arch":
symbol.ARCH = value
elif option == "--chrome-symbols-dir":
- symbol.CHROME_SYMBOLS_DIR = os.path.join(symbol.CHROME_SYMBOLS_DIR, value)
+ symbol.CHROME_SYMBOLS_DIR = os.path.join(symbol.CHROME_SRC, value)
elif option == "--more-info":
more_info = True
elif option == "--less-info":
@@ -164,7 +164,8 @@ def main(argv):
rootdir, symbol.SYMBOLS_DIR = UnzipSymbols(zip_arg)
print "Reading Android symbols from", symbol.SYMBOLS_DIR
- print "Reading Chrome symbols from", symbol.CHROME_SYMBOLS_DIR
+ chrome_search_path = symbol.GetLibrarySearchPaths()
+ print "Searching for Chrome symbols from within", ':'.join(chrome_search_path)
stack_core.ConvertTrace(lines, more_info)
if rootdir:
« no previous file with comments | « no previous file | third_party/android_platform/development/scripts/symbol.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698