chrome/browser/chrome_browser_main_android.cc - Issue 1412293002: Android: Make stack tool work for GN builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main_android.cc

Issue 1412293002: Android: Make stack tool work for GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_browser_main_android.cc

diff --git a/chrome/browser/chrome_browser_main_android.cc b/chrome/browser/chrome_browser_main_android.cc

index 4fd6d9d710200af8f35ce61a540c1c81723864ef..101873b825776c33f8417ace49acd54ae13bf54f 100644

--- a/chrome/browser/chrome_browser_main_android.cc

+++ b/chrome/browser/chrome_browser_main_android.cc

@@ -48,6 +48,7 @@ ChromeBrowserMainPartsAndroid::~ChromeBrowserMainPartsAndroid() {

int ChromeBrowserMainPartsAndroid::PreCreateThreads() {

TRACE_EVENT0("startup", "ChromeBrowserMainPartsAndroid::PreCreateThreads")

+ DCHECK(false) << "HA";

johnme 2015/10/20 18:53:27 I take it this is accidental ;)

agrieve 2015/10/20 19:27:49 yeah... about that... :P

// The CrashDumpManager must be initialized before any child process is

// created (as they need to access it during creation). Such processes