Translate 802.1x WEP ("Enterprise WEP")

Translate 802.1x WEP ("Enterprise WEP")

This CL adds translation of "Enterprise WEP": 802.1x authentication
with WEP encryption.

BUG=551085
TEST=New unit tests
R=stevenjb@chromium.org

Committed: https://crrev.com/418647a8740a5ea7314d224721728abbadf2f236
Cr-Commit-Position: refs/heads/master@{#357867}

[stevenjb, 2015-11-03 23:09:26]

Thanks for putting this together. Looks good with the missing test files added.

https://codereview.chromium.org/1412283006/diff/1/chromeos/network/onc/onc_tr...
File chromeos/network/onc/onc_translator_unittest.cc (right):

https://codereview.chromium.org/1412283006/diff/1/chromeos/network/onc/onc_tr...
chromeos/network/onc/onc_translator_unittest.cc:55:
"shill_wifi_wep_8021x_clientcert.json"),
I assume these files need to be added to the CL?

https://codereview.chromium.org/1412283006/diff/1/chromeos/network/onc/onc_tr...
chromeos/network/onc/onc_translator_unittest.cc:112:
"translation_of_shill_wifi_wep_8021x_clientcert.onc"),
And these?

[stevenjb, 2015-11-04 00:14:57]

https://codereview.chromium.org/1412283006/diff/20001/chromeos/network/onc/on...
File chromeos/network/onc/onc_translator_onc_to_shill.cc (right):

https://codereview.chromium.org/1412283006/diff/20001/chromeos/network/onc/on...
chromeos/network/onc/onc_translator_onc_to_shill.cc:225:
shill::kEapKeyMgmtProperty, ::onc::wifi::kKeyMgmtIEEE8021X);
Sorry, missed this the first time through. We shouldn't set a shill property
using an ONC constant. kKeyMgmtIEEE8021X should ideally be part of
service_constants.h. In the near term it can be defined in a file local
namespace.

[Paul Stewart, 2015-11-04 18:26:23]

PTAL

https://codereview.chromium.org/1412283006/diff/20001/chromeos/network/onc/on...
File chromeos/network/onc/onc_translator_onc_to_shill.cc (right):

https://codereview.chromium.org/1412283006/diff/20001/chromeos/network/onc/on...
chromeos/network/onc/onc_translator_onc_to_shill.cc:225:
shill::kEapKeyMgmtProperty, ::onc::wifi::kKeyMgmtIEEE8021X);
On 2015/11/04 00:14:57, stevenjb wrote:
> Sorry, missed this the first time through. We shouldn't set a shill property
> using an ONC constant. kKeyMgmtIEEE8021X should ideally be part of
> service_constants.h. In the near term it can be defined in a file local
> namespace.
> 

Done.

[stevenjb, 2015-11-04 18:36:00]

lgtm

https://codereview.chromium.org/1412283006/diff/40001/chromeos/network/onc/on...
File chromeos/network/onc/onc_translator_onc_to_shill.cc (right):

https://codereview.chromium.org/1412283006/diff/40001/chromeos/network/onc/on...
chromeos/network/onc/onc_translator_onc_to_shill.cc:32: const char
kKeyManagementIEEE8021X[] = "IEEE8021X";
nit: Add a TODO here to use the value in service_constants once available.

https://codereview.chromium.org/1412283006/diff/40001/chromeos/network/onc/on...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/1412283006/diff/40001/chromeos/network/onc/on...
chromeos/network/onc/onc_translator_shill_to_onc.cc:30: const char
kKeyManagementIEEE8021X[] = "IEEE8021X";
nit: TODO

[Paul Stewart, 2015-11-04 18:52:45]

The CQ bit was checked by pstew@chromium.org

[Paul Stewart, 2015-11-04 18:52:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1412283006/#ps60001
(title: "Added TODOs")

[commit-bot: I haz the power, 2015-11-04 18:54:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412283006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412283006/60001

[commit-bot: I haz the power, 2015-11-04 19:21:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-04 19:23:28]

Patchset 4 (id:??) landed as
https://crrev.com/418647a8740a5ea7314d224721728abbadf2f236
Cr-Commit-Position: refs/heads/master@{#357867}