Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412283002: Convert mojo::system::Dispatcher to use our new refcounting stuff (instead of base's). (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
vardhan
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Convert mojo::system::Dispatcher to use our new refcounting stuff (instead of base's). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1a0ba96215c5a47a8358b57adefb3b70cb4c9698

Patch Set 1 #

Patch Set 2 : "rebased" #

Patch Set 3 : no change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -538 lines) Patch
M mojo/edk/embedder/embedder.cc View 9 chunks +17 lines, -24 lines 0 comments Download
M mojo/edk/embedder/system_impl_private_entrypoints.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/channel_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/channel_manager.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M mojo/edk/system/channel_manager_unittest.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M mojo/edk/system/core.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/core.cc View 17 chunks +31 lines, -41 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 4 chunks +6 lines, -7 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 8 chunks +31 lines, -33 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 4 chunks +6 lines, -7 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 11 chunks +11 lines, -14 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 9 chunks +15 lines, -19 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 1 7 chunks +13 lines, -11 lines 0 comments Download
M mojo/edk/system/handle_table.h View 5 chunks +10 lines, -12 lines 0 comments Download
M mojo/edk/system/handle_table.cc View 7 chunks +16 lines, -17 lines 0 comments Download
M mojo/edk/system/ipc_support.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/ipc_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 14 chunks +60 lines, -67 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 4 chunks +7 lines, -9 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 1 12 chunks +19 lines, -19 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.h View 4 chunks +5 lines, -6 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 9 chunks +15 lines, -18 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 17 chunks +37 lines, -36 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 3 chunks +10 lines, -11 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 6 chunks +21 lines, -15 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 7 chunks +40 lines, -39 lines 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 1 18 chunks +29 lines, -26 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-19 19:32:27 UTC) #1
viettrungluu
Could you rubberstamp this when you have a chance?
5 years, 2 months ago (2015-10-19 23:45:57 UTC) #2
vardhan
lgtm
5 years, 2 months ago (2015-10-19 23:49:42 UTC) #3
viettrungluu
5 years, 2 months ago (2015-10-20 00:00:32 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
1a0ba96215c5a47a8358b57adefb3b70cb4c9698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698