Issue 1412273004: Ensure that RESOLVED_UNITx ready once for every library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1412273004: Ensure that RESOLVED_UNITx ready once for every library. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Ensure that RESOLVED_UNITx ready once for every library. ...instead of ensuring this separately for complete closures of every library. This improves initial analysis performance from about 44 seconds to 39. This also makes WorkOrder.moveNext less expensive - to about 5.6% during initial analysis. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/041e61a0f63467612635a3cead6e999f7ca7b485

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+175 lines, -17 lines)			Patch
M	pkg/analysis_server/test/analysis_server_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/plugin/engine_plugin.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	6 chunks	+159 lines, -14 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/driver.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 1 month ago (2015-10-23 20:26:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
041e61a0f63467612635a3cead6e999f7ca7b485 (presubmit successful).

Expand Messages | Collapse Messages