components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java - Issue 1412243012: Initial implementation of CronetBidirectionalStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

Issue 1412243012: Initial implementation of CronetBidirectionalStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Helen's comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/BUILD.gn ('K') | « components/cronet/android/BUILD.gn ('k') | components/cronet/android/cronet_bidirectional_stream_adapter.h » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

diff --git a/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java b/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

index af42976021dee1556d156b27caed8a732299d2e2..3c5f19ca646184794a919c872704e639562280dc 100644

--- a/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

+++ b/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

@@ -88,7 +88,7 @@ public abstract class BidirectionalStream {

public Builder setHttpMethod(String method) {

if (method == null) {

- throw new NullPointerException("Invalid method name.");

+ throw new NullPointerException("Method is required.");

}

mHttpMethod = method;

return this;