components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java - Issue 1412243012: Initial implementation of CronetBidirectionalStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java

Issue 1412243012: Initial implementation of CronetBidirectionalStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More Helen's and Andrei's comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java ('K') | « components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java ('k') | components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java » ('j') | components/cronet/android/test/src/org/chromium/net/Http2TestServer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java

diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java

index d5692111472ff7eb7ab9d1397cc3a7e0fce5108c..3e016d79ada51e149cc6c3ef3ea49e963f20de23 100644

--- a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java

+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java

@@ -190,7 +190,7 @@ final class CronetUrlRequest implements UrlRequest {

try {

mUrlRequestAdapter = nativeCreateRequestAdapter(

mRequestContext.getUrlRequestContextAdapter(), mInitialUrl, mPriority);

- mRequestContext.onRequestStarted(this);

+ mRequestContext.onRequestStarted();

if (mInitialMethod != null) {

if (!nativeSetHttpMethod(mUrlRequestAdapter, mInitialMethod)) {

throw new IllegalArgumentException("Invalid http method " + mInitialMethod);

@@ -435,7 +435,7 @@ final class CronetUrlRequest implements UrlRequest {

}

nativeDestroy(mUrlRequestAdapter, sendOnCanceled);

mRequestContext.reportFinished(this);

- mRequestContext.onRequestDestroyed(this);

+ mRequestContext.onRequestDestroyed();

mUrlRequestAdapter = 0;

if (mOnDestroyedCallbackForTesting != null) {

mOnDestroyedCallbackForTesting.run();