Initial implementation of CronetBidirectionalStream.

components/cronet/android/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//build/buildflag_header.gni")
 import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//build/util/version.gni")
 import("//chrome/version.gni")
 import("//testing/test.gni")
 
 assert(!is_component_build, "Cronet requires static library build.")
 
 declare_args() {
   cronet_enable_data_reduction_proxy_support = false
 }
 
 generate_jni("cronet_jni_headers") {
   sources = [
     "java/src/org/chromium/net/ChromiumUrlRequest.java",
     "java/src/org/chromium/net/ChromiumUrlRequestContext.java",
+    "java/src/org/chromium/net/CronetBidirectionalStream.java",
     "java/src/org/chromium/net/CronetLibraryLoader.java",
     "java/src/org/chromium/net/CronetUploadDataStream.java",
     "java/src/org/chromium/net/CronetUrlRequest.java",
     "java/src/org/chromium/net/CronetUrlRequestContext.java",
   ]
   jni_package = "cronet"
 }
 
 java_cpp_enum("cronet_url_request_java") {
   sources = [
@@ skipping 63 matching lines @@
 #   defines: Extra defines.
 #   deps: Extra dependencies.
 template("cronet_static_tmpl") {
   source_set(target_name) {
     defines = []
 
     deps = [
       ":cronet_jni_headers",
       ":cronet_url_request_java",
       ":cronet_version_header",
+      ":features",
       "//base",
       "//base:i18n",
       "//base:prefs",
       "//base/third_party/dynamic_annotations",
       "//components/metrics",
     ]
     sources = [
       "//components/cronet/android/chromium_url_request.cc",
       "//components/cronet/android/chromium_url_request.h",
       "//components/cronet/android/chromium_url_request_context.cc",
@@ skipping 35 matching lines @@
     ]
 
     if (cronet_enable_data_reduction_proxy_support) {
       defines += [ "DATA_REDUCTION_PROXY_SUPPORT" ]
       sources += [
         "//components/cronet/android/cronet_data_reduction_proxy.cc",
         "//components/cronet/android/cronet_data_reduction_proxy.h",
       ]
     }
 
+    if (enable_bidirectional_stream) {
+      sources += [
+        "//components/cronet/android/cronet_bidirectional_stream_adapter.cc",
+        "//components/cronet/android/cronet_bidirectional_stream_adapter.h",
+      ]
+    }
+
     if (defined(invoker.defines)) {
       defines += invoker.defines
     }
 
     if (defined(invoker.deps)) {
       deps += invoker.deps
     }
   }
 }
 
@@ skipping 63 matching lines @@
   ]
 
   run_findbugs = true
 }
 
 android_library("cronet_java") {
   java_files = [
     "java/src/org/chromium/net/ChromiumUrlRequest.java",
     "java/src/org/chromium/net/ChromiumUrlRequestContext.java",
     "java/src/org/chromium/net/ChromiumUrlRequestFactory.java",
+    "java/src/org/chromium/net/CronetBidirectionalStream.java",
     "java/src/org/chromium/net/CronetLibraryLoader.java",
     "java/src/org/chromium/net/CronetUploadDataStream.java",
     "java/src/org/chromium/net/CronetUrlRequest.java",
     "java/src/org/chromium/net/CronetUrlRequestContext.java",
     "java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java",
     "java/src/org/chromium/net/urlconnection/CronetChunkedOutputStream.java",
     "java/src/org/chromium/net/urlconnection/CronetFixedModeOutputStream.java",
     "java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java",
     "java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java",
     "java/src/org/chromium/net/urlconnection/CronetInputStream.java",
@@ skipping 424 matching lines @@
     ":cronet_package_copy_native_lib",
     ":cronet_package_copy_native_lib_unstripped",
     ":generate_javadoc",
     ":generate_licenses",
     ":jar_cronet_api_source",
     ":jar_cronet_other_source",
     ":jar_cronet_sample_source",
     ":repackage_extracted_jars",
   ]
 }
+
+buildflag_header("features") {
+  header = "../cronet_features.h"
+
+  flags = [ "ENABLE_BIDIRECTIONAL_STREAM=$enable_bidirectional_stream" ]

[pauljensen, 2016/01/19 16:03:39]

Could we instead do this like we do DATA_REDUCTION_PROXY_SUPPORT on line 155?
Seems a bit simpler, and having the flag undefined when BiDiStream support is
missing seems less error prone (e.g. less likely someone accidentally writes
"#ifdef ENABLE_BIDI_STREAM")

[mef, 2016/01/20 15:37:39]

Build flags are the new hotness":
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/build_...

The benefit is compile-time check that flag is defined one way or another. 

+}