Initial implementation of CronetBidirectionalStream.

components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.os.Build;
 import android.os.ConditionVariable;
 import android.os.Handler;
 import android.os.Looper;
@@ skipping 131 matching lines @@
 
     @Override
     public UrlRequest createRequest(String url, UrlRequest.Callback callback, Executor executor,
             int priority, Collection<Object> requestAnnotations) {
         synchronized (mLock) {
             checkHaveAdapter();
             boolean metricsCollectionEnabled = mNetworkQualityEstimatorEnabled;
             if (metricsCollectionEnabled) { // Collect metrics only if someone is listening.
                 synchronized (mNetworkQualityLock) {
                     metricsCollectionEnabled = !mFinishedListenerList.isEmpty();
                 }

[pauljensen, 2016/01/04 19:56:00]

I imagine there will be demand for metrics collection for bidi streams.  Are you
planning this for a future CL?

[mef, 2016/01/04 22:27:08]

Yes, but not in this CL.

             }
             return new CronetUrlRequest(this, mUrlRequestContextAdapter, url, priority, callback,
                     executor, requestAnnotations, metricsCollectionEnabled);
         }
     }
 
     @Override
     BidirectionalStream createBidirectionalStream(String url, BidirectionalStream.Callback callback,
             Executor executor, String httpMethod, List<Map.Entry<String, String>> requestHeaders,
             @BidirectionalStream.Builder.StreamPriority int priority) {
-        throw new UnsupportedOperationException();
+        synchronized (mLock) {
+            checkHaveAdapter();
+            return new CronetBidirectionalStream(this, mUrlRequestContextAdapter, url, priority,
+                    callback, executor, httpMethod, requestHeaders);
+        }
     }
 
     @Override
     public boolean isEnabled() {
         return Build.VERSION.SDK_INT >= 14;
     }
 
     @Override
     public String getVersionString() {
         return "Cronet/" + Version.getVersion();
@@ skipping 179 matching lines @@
 
     @Override
     public URLStreamHandlerFactory createURLStreamHandlerFactory() {
         return new CronetURLStreamHandlerFactory(this);
     }
 
     /**
      * Mark request as started to prevent shutdown when there are active
      * requests.
      */
-    void onRequestStarted(UrlRequest urlRequest) {
+    void onRequestStarted() {
         mActiveRequestCount.incrementAndGet();
     }
 
     /**
      * Mark request as finished to allow shutdown when there are no active
      * requests.
      */
-    void onRequestDestroyed(UrlRequest urlRequest) {
+    void onRequestDestroyed() {
         mActiveRequestCount.decrementAndGet();
     }
 
     @VisibleForTesting
     long getUrlRequestContextAdapter() {
         synchronized (mLock) {
             checkHaveAdapter();
             return mUrlRequestContextAdapter;
         }
     }
@@ skipping 130 matching lines @@
     @NativeClassQualifiedName("CronetURLRequestContextAdapter")
     private native void nativeEnableNetworkQualityEstimator(
             long nativePtr, boolean useLocalHostRequests, boolean useSmallerResponses);
 
     @NativeClassQualifiedName("CronetURLRequestContextAdapter")
     private native void nativeProvideRTTObservations(long nativePtr, boolean should);
 
     @NativeClassQualifiedName("CronetURLRequestContextAdapter")
     private native void nativeProvideThroughputObservations(long nativePtr, boolean should);
 }