Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412243004: Fix build targets for some bots (Closed)

Created:
5 years, 2 months ago by borenet
Modified:
5 years, 2 months ago
Reviewers:
msarett, rmistry
CC:
reviews_skia.org, msarett
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix build targets for some bots Valgrind bot is not building nanobench. Some bots are building nanobench and then not running it. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b64b195dbde1b3854ab8285c1db2c3b1fb217971

Patch Set 1 : Fix test expectations #

Patch Set 2 : Fix build targets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1989 lines, -68 lines) Patch
M tools/buildbot_spec.json View 1 65 chunks +1978 lines, -57 lines 0 comments Download
M tools/buildbot_spec.py View 1 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
borenet
Patch set 1 just fixes the test expectations, which were out of date. The diff ...
5 years, 2 months ago (2015-10-21 14:38:24 UTC) #3
rmistry
lgtm
5 years, 2 months ago (2015-10-21 14:39:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412243004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412243004/20001
5 years, 2 months ago (2015-10-21 14:41:19 UTC) #6
msarett
lgtm
5 years, 2 months ago (2015-10-21 14:42:05 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 14:51:01 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b64b195dbde1b3854ab8285c1db2c3b1fb217971

Powered by Google App Engine
This is Rietveld 408576698