Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412243003: Mark RFH::AllowInjectingJavaScriptForAndroidWebView as Android only. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark RFH::AllowInjectingJavaScriptForAndroidWebView as Android only. Also do IYWU for chrome_isolated_world_ids.h. Committed: https://crrev.com/9a20461563acb807fc3f884b6e42bafe2ec9e822 Cr-Commit-Position: refs/heads/master@{#355014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/common/chrome_isolated_world_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/render_frame_host.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
Just a cleanup, no rush.
5 years, 2 months ago (2015-10-19 20:36:22 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-20 08:28:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412243003/1
5 years, 2 months ago (2015-10-20 08:54:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 09:00:04 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 09:01:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9a20461563acb807fc3f884b6e42bafe2ec9e822
Cr-Commit-Position: refs/heads/master@{#355014}

Powered by Google App Engine
This is Rietveld 408576698