Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: content/public/android/java/src/org/chromium/content/app/ChildProcessService.java

Issue 141223002: Move the android library loader from content to base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix final nits Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/app/ChildProcessService.java
diff --git a/content/public/android/java/src/org/chromium/content/app/ChildProcessService.java b/content/public/android/java/src/org/chromium/content/app/ChildProcessService.java
index 2898d423444fad86298329a9fdf2780367cb0972..769249ed095bc6568d765df6237b0e1407bba312 100644
--- a/content/public/android/java/src/org/chromium/content/app/ChildProcessService.java
+++ b/content/public/android/java/src/org/chromium/content/app/ChildProcessService.java
@@ -18,11 +18,13 @@ import android.view.Surface;
import org.chromium.base.CalledByNative;
import org.chromium.base.JNINamespace;
+import org.chromium.base.library_loader.LibraryLoader;
+import org.chromium.base.library_loader.Linker;
+import org.chromium.base.library_loader.ProcessInitException;
import org.chromium.content.browser.ChildProcessConnection;
import org.chromium.content.browser.ChildProcessLauncher;
import org.chromium.content.common.IChildProcessCallback;
import org.chromium.content.common.IChildProcessService;
-import org.chromium.content.common.ProcessInitException;
import java.util.ArrayList;
import java.util.concurrent.atomic.AtomicReference;
@@ -53,7 +55,7 @@ public class ChildProcessService extends Service {
private ArrayList<Integer> mFileIds;
private ArrayList<ParcelFileDescriptor> mFileFds;
// Linker-specific parameters for this child process service.
- private LinkerParams mLinkerParams;
+ private ChromiumLinkerParams mLinkerParams;
private static AtomicReference<Context> sContext = new AtomicReference<Context>(null);
private boolean mLibraryInitialized = false;
@@ -196,6 +198,7 @@ public class ChildProcessService extends Service {
mMainThread.wait();
}
} catch (InterruptedException e) {
+ // Ignore
}
}
// Try to shutdown the MainThread gracefully, but it might not
@@ -216,7 +219,7 @@ public class ChildProcessService extends Service {
ChildProcessConnection.EXTRA_COMMAND_LINE);
mLinkerParams = null;
if (Linker.isUsed())
- mLinkerParams = new LinkerParams(intent);
+ mLinkerParams = new ChromiumLinkerParams(intent);
mIsBound = true;
mMainThread.notifyAll();
}

Powered by Google App Engine
This is Rietveld 408576698