Move the android library loader from content to base

content/shell/android/linker_test_apk/chromium_linker_test_android.cc

Index: content/shell/android/linker_test_apk/chromium_linker_test_android.cc
diff --git a/content/shell/android/linker_test_apk/content_linker_test_android.cc b/content/shell/android/linker_test_apk/chromium_linker_test_android.cc
similarity index 81%
rename from content/shell/android/linker_test_apk/content_linker_test_android.cc
rename to content/shell/android/linker_test_apk/chromium_linker_test_android.cc
index 42c01d0e9407bcb1b7c47f558459af1ed070f02f..a1799c861322ef39250634feb1e7ae4aaf539ea8 100644
--- a/content/shell/android/linker_test_apk/content_linker_test_android.cc
+++ b/content/shell/android/linker_test_apk/chromium_linker_test_android.cc
@@ -4,22 +4,26 @@
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_registrar.h"
+#include "base/android/library_loader/library_loader_hooks.h"
 #include "base/basictypes.h"
 #include "base/debug/debugger.h"
 #include "base/logging.h"
 #include "content/public/app/android_library_loader_hooks.h"
 #include "content/public/app/content_main.h"
 #include "content/public/browser/android/compositor.h"
-#include "content/shell/android/linker_test_apk/content_linker_test_linker_tests.h"
+#include "content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.h"
 #include "content/shell/android/shell_jni_registrar.h"
 #include "content/shell/app/shell_main_delegate.h"
 
 // This is called by the VM when the shared library is first loaded.
 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
+
+  base::android::SetLibraryLoadedHook(&content::LibraryLoaded);

[Yaron, 2014/02/04 05:50:01]

It's not really clear what the difference is between SetLibraryLoadedHook and
RegisterLibraryLoaderEntryHook. Perhaps they can be merged in a follow-up since
one is essentially saying to register the JNI function for when the library is
loaded and the other is the callback once loading is done. Ok to do in a
follow-up

[aberent, 2014/02/05 13:40:14]

I think their functions are actually different, although they almost always both
have to be called during JNI_OnLoad. RegisterLibraryLoaderEntryHook registers,
when it is called, the JNI functions needed by the library loader itself.
SetLibraryLoadedHook sets up a function to be called when the Java side chooses
to call nativeLibraryLoaded (which, in theory, might be some time after the
library is loaded).  Having said this, if I can find a good name for what the
combined function does I will combine them in a future CL.

I did consider changing the name of RegisterLibraryLoaderEntryHook 
to something like RegisterLibraryLoaderJni, but felt I was already changing
enough in this CL.

On 2014/02/04 05:50:01, Yaron wrote:

+
   base::android::InitVM(vm);
   JNIEnv* env = base::android::AttachCurrentThread();
 
-  if (!content::RegisterLibraryLoaderEntryHook(env))
+  if (!base::android::RegisterLibraryLoaderEntryHook(env))
     return -1;
 
   // To be called only from the UI thread.  If loading the library is done on