Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: src/snapshot/serialize.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/snapshot/serialize.h ('k') | src/typing-asm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/serialize.cc
diff --git a/src/snapshot/serialize.cc b/src/snapshot/serialize.cc
index d9931ce1f70577effd335cb611a314b1496c283b..effa5c45576bee3547eb9233d5918752c6774ce5 100644
--- a/src/snapshot/serialize.cc
+++ b/src/snapshot/serialize.cc
@@ -361,18 +361,17 @@ class CodeAddressMap: public CodeEventLogger {
isolate->logger()->addCodeEventListener(this);
}
- virtual ~CodeAddressMap() {
+ ~CodeAddressMap() override {
isolate_->logger()->removeCodeEventListener(this);
}
- virtual void CodeMoveEvent(Address from, Address to) {
+ void CodeMoveEvent(Address from, Address to) override {
address_to_name_map_.Move(from, to);
}
- virtual void CodeDisableOptEvent(Code* code, SharedFunctionInfo* shared) {
- }
+ void CodeDisableOptEvent(Code* code, SharedFunctionInfo* shared) override {}
- virtual void CodeDeleteEvent(Address from) {
+ void CodeDeleteEvent(Address from) override {
address_to_name_map_.Remove(from);
}
@@ -452,10 +451,8 @@ class CodeAddressMap: public CodeEventLogger {
DISALLOW_COPY_AND_ASSIGN(NameMap);
};
- virtual void LogRecordedBuffer(Code* code,
- SharedFunctionInfo*,
- const char* name,
- int length) {
+ void LogRecordedBuffer(Code* code, SharedFunctionInfo*, const char* name,
+ int length) override {
address_to_name_map_.Insert(code->address(), name, length);
}
@@ -677,7 +674,7 @@ class StringTableInsertionKey : public HashTableKey {
return String::cast(key)->Hash();
}
- MUST_USE_RESULT virtual Handle<Object> AsHandle(Isolate* isolate) override {
+ MUST_USE_RESULT Handle<Object> AsHandle(Isolate* isolate) override {
return handle(string_, isolate);
}
« no previous file with comments | « src/snapshot/serialize.h ('k') | src/typing-asm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698