Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: src/heap/spaces.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/spaces.h ('k') | src/ic/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/spaces.h" 5 #include "src/heap/spaces.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/platform/platform.h" 8 #include "src/base/platform/platform.h"
9 #include "src/full-codegen/full-codegen.h" 9 #include "src/full-codegen/full-codegen.h"
10 #include "src/heap/slots-buffer.h" 10 #include "src/heap/slots-buffer.h"
(...skipping 2914 matching lines...) Expand 10 before | Expand all | Expand 10 after
2925 HeapObjectIterator obj_it(this); 2925 HeapObjectIterator obj_it(this);
2926 for (HeapObject* obj = obj_it.Next(); obj != NULL; obj = obj_it.Next()) 2926 for (HeapObject* obj = obj_it.Next(); obj != NULL; obj = obj_it.Next())
2927 CollectHistogramInfo(obj); 2927 CollectHistogramInfo(obj);
2928 ReportHistogram(heap()->isolate(), true); 2928 ReportHistogram(heap()->isolate(), true);
2929 } 2929 }
2930 #endif 2930 #endif
2931 2931
2932 2932
2933 // ----------------------------------------------------------------------------- 2933 // -----------------------------------------------------------------------------
2934 // MapSpace implementation 2934 // MapSpace implementation
2935 // TODO(mvstanton): this is weird...the compiler can't make a vtable unless
2936 // there is at least one non-inlined virtual function. I would prefer to hide
2937 // the VerifyObject definition behind VERIFY_HEAP.
2938 2935
2936 #ifdef VERIFY_HEAP
2939 void MapSpace::VerifyObject(HeapObject* object) { CHECK(object->IsMap()); } 2937 void MapSpace::VerifyObject(HeapObject* object) { CHECK(object->IsMap()); }
2938 #endif
2940 2939
2941 2940
2942 // ----------------------------------------------------------------------------- 2941 // -----------------------------------------------------------------------------
2943 // LargeObjectIterator 2942 // LargeObjectIterator
2944 2943
2945 LargeObjectIterator::LargeObjectIterator(LargeObjectSpace* space) { 2944 LargeObjectIterator::LargeObjectIterator(LargeObjectSpace* space) {
2946 current_ = space->first_page_; 2945 current_ = space->first_page_;
2947 } 2946 }
2948 2947
2949 2948
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
3271 object->ShortPrint(); 3270 object->ShortPrint();
3272 PrintF("\n"); 3271 PrintF("\n");
3273 } 3272 }
3274 printf(" --------------------------------------\n"); 3273 printf(" --------------------------------------\n");
3275 printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes()); 3274 printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes());
3276 } 3275 }
3277 3276
3278 #endif // DEBUG 3277 #endif // DEBUG
3279 } // namespace internal 3278 } // namespace internal
3280 } // namespace v8 3279 } // namespace v8
OLDNEW
« no previous file with comments | « src/heap/spaces.h ('k') | src/ic/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698