Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2446)

Side by Side Diff: src/ast-numbering.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast-literal-reindexer.h ('k') | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast-numbering.h" 5 #include "src/ast-numbering.h"
6 6
7 #include "src/ast.h" 7 #include "src/ast.h"
8 #include "src/scopes.h" 8 #include "src/scopes.h"
9 9
10 namespace v8 { 10 namespace v8 {
11 namespace internal { 11 namespace internal {
12 12
13 class AstNumberingVisitor final : public AstVisitor { 13 class AstNumberingVisitor final : public AstVisitor {
14 public: 14 public:
15 AstNumberingVisitor(Isolate* isolate, Zone* zone) 15 AstNumberingVisitor(Isolate* isolate, Zone* zone)
16 : AstVisitor(), 16 : AstVisitor(),
17 isolate_(isolate), 17 isolate_(isolate),
18 zone_(zone), 18 zone_(zone),
19 next_id_(BailoutId::FirstUsable().ToInt()), 19 next_id_(BailoutId::FirstUsable().ToInt()),
20 properties_(zone), 20 properties_(zone),
21 slot_cache_(zone), 21 slot_cache_(zone),
22 dont_optimize_reason_(kNoReason) { 22 dont_optimize_reason_(kNoReason) {
23 InitializeAstVisitor(isolate); 23 InitializeAstVisitor(isolate);
24 } 24 }
25 25
26 bool Renumber(FunctionLiteral* node); 26 bool Renumber(FunctionLiteral* node);
27 27
28 private: 28 private:
29 // AST node visitor interface. 29 // AST node visitor interface.
30 #define DEFINE_VISIT(type) virtual void Visit##type(type* node) override; 30 #define DEFINE_VISIT(type) void Visit##type(type* node) override;
31 AST_NODE_LIST(DEFINE_VISIT) 31 AST_NODE_LIST(DEFINE_VISIT)
32 #undef DEFINE_VISIT 32 #undef DEFINE_VISIT
33 33
34 bool Finish(FunctionLiteral* node); 34 bool Finish(FunctionLiteral* node);
35 35
36 void VisitVariableProxyReference(VariableProxy* node); 36 void VisitVariableProxyReference(VariableProxy* node);
37 void VisitPropertyReference(Property* node); 37 void VisitPropertyReference(Property* node);
38 void VisitReference(Expression* expr); 38 void VisitReference(Expression* expr);
39 39
40 void VisitStatements(ZoneList<Statement*>* statements) override; 40 void VisitStatements(ZoneList<Statement*>* statements) override;
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 } 583 }
584 584
585 585
586 bool AstNumbering::Renumber(Isolate* isolate, Zone* zone, 586 bool AstNumbering::Renumber(Isolate* isolate, Zone* zone,
587 FunctionLiteral* function) { 587 FunctionLiteral* function) {
588 AstNumberingVisitor visitor(isolate, zone); 588 AstNumberingVisitor visitor(isolate, zone);
589 return visitor.Renumber(function); 589 return visitor.Renumber(function);
590 } 590 }
591 } // namespace internal 591 } // namespace internal
592 } // namespace v8 592 } // namespace v8
OLDNEW
« no previous file with comments | « src/ast-literal-reindexer.h ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698