Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1412223002: SkRemote: add xfermodes (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkRemote: add xfermodes Note this changes the default ID for each type from a valid non-null value to a nullptr. All the ()++ are now ++(), so we always work with non-null IDs when we define things. Some of this is prematurely generalized with an eye for supporting other effects and ref-counted things. https://gold.skia.org/search2?issue=1412223002&unt=true&query=source_type%3Dgm&master=false&include=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c4d934f339693ecd039de05e9d882691adb7ec0f

Patch Set 1 #

Patch Set 2 : better #

Patch Set 3 : whoops #

Patch Set 4 : notes #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -67 lines) Patch
M src/core/SkRemote.h View 1 2 3 5 chunks +76 lines, -17 lines 0 comments Download
M src/core/SkRemote.cpp View 1 2 3 4 5 chunks +107 lines, -46 lines 0 comments Download
M src/core/SkRemote_protocol.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223002/60001
5 years, 2 months ago (2015-10-19 19:20:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-19 19:34:10 UTC) #9
mtklein_C
5 years, 2 months ago (2015-10-19 19:57:58 UTC) #12
hal.canary
lgtm
5 years, 2 months ago (2015-10-20 14:47:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223002/60001
5 years, 2 months ago (2015-10-20 14:47:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3308)
5 years, 2 months ago (2015-10-20 14:49:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223002/80001
5 years, 2 months ago (2015-10-20 15:17:49 UTC) #20
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 15:26:56 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/c4d934f339693ecd039de05e9d882691adb7ec0f

Powered by Google App Engine
This is Rietveld 408576698