Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1412213003: Register .analysis_options files for analysis. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Register .analysis_options files for analysis. Some oportunistic constant cleanup as well (follow-up from: https://codereview.chromium.org/1399893004/). R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/140a4f5891a4e7fbd716e6e3100dd68ed03c5e97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -27 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 5 chunks +14 lines, -20 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 2 months ago (2015-10-19 16:37:50 UTC) #2
scheglov
lgtm
5 years, 2 months ago (2015-10-19 16:42:40 UTC) #3
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-19 16:46:18 UTC) #4
pquitslund
5 years, 2 months ago (2015-10-19 16:46:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
140a4f5891a4e7fbd716e6e3100dd68ed03c5e97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698