Identity API: component app images

Identity API: component app images

These images will be used in a component app for Identity API UI.

BUG=228908
(These images are part of step #6 in the description.)

[Michael Courage, 2013-04-22 20:01:55]

Just adding some images so I can get the bots to run a change that uses them.

[Evan Stade, 2013-04-22 21:43:23]

On 2013/04/22 20:01:55, Michael Courage wrote:
> Just adding some images so I can get the bots to run a change that uses them.

I can't see the images but I wonder why you're not reusing the window close
resources we use for other dialogs?

[Michael Courage, 2013-04-22 22:02:33]

On 2013/04/22 21:43:23, Evan Stade wrote:
> On 2013/04/22 20:01:55, Michael Courage wrote:
> > Just adding some images so I can get the bots to run a change that uses
them.
> 
> I can't see the images but I wonder why you're not reusing the window close
> resources we use for other dialogs?

These files are actually identical to
ash/resources/default_100_percent/common/window_close_short_*.png, which match
the comps I got for the Identity dialogs. Those files seem to move and change a
fair amount though, so I wasn't sure if it was safe to point at them.

What's the ideal way to refer to those images? Point IDR_IDENTITY_API_UI_* at
the ash/resources files? Re-use the resource IDs of the originals?

[Evan Stade, 2013-04-22 22:13:23]

On 2013/04/22 22:02:33, Michael Courage wrote:
> On 2013/04/22 21:43:23, Evan Stade wrote:
> > On 2013/04/22 20:01:55, Michael Courage wrote:
> > > Just adding some images so I can get the bots to run a change that uses
> them.
> > 
> > I can't see the images but I wonder why you're not reusing the window close
> > resources we use for other dialogs?
> 
> These files are actually identical to
> ash/resources/default_100_percent/common/window_close_short_*.png, which match
> the comps I got for the Identity dialogs. Those files seem to move and change
a
> fair amount though, so I wasn't sure if it was safe to point at them.
> 
> What's the ideal way to refer to those images? Point IDR_IDENTITY_API_UI_* at
> the ash/resources files? Re-use the resource IDs of the originals?

I guess I'm wondering why you aren't using IDR_CLOSE_DIALOG
(ui/resources/default_100_percent/close_dialog.png)

[Michael Courage, 2013-04-22 23:33:30]

On 2013/04/22 22:13:23, Evan Stade wrote:
> I guess I'm wondering why you aren't using IDR_CLOSE_DIALOG
> (ui/resources/default_100_percent/close_dialog.png)

Originally I chose these because they looked slightly more like a comp I had for
the dialog. They're pretty close though, and I'm pretty sure IDR_CLOSE_DIALOG
would be fine visually.

The other concern I'd have is that this UI is a component Chrome App with a
custom frame, rather than a standard dialog box. If someone changed the dialog
frame, it might not be obvious to them that they should make sure the Identity
API component app still looks right. However, on searching I did find some other
web UI's that use the same images, so maybe it's safer than I thought.

If you think that's the right way to go, I can drop this CL.

[Evan Stade, 2013-04-23 01:23:19]

On 2013/04/22 23:33:30, Michael Courage wrote:
> On 2013/04/22 22:13:23, Evan Stade wrote:
> > I guess I'm wondering why you aren't using IDR_CLOSE_DIALOG
> > (ui/resources/default_100_percent/close_dialog.png)
> 
> Originally I chose these because they looked slightly more like a comp I had
for
> the dialog. They're pretty close though, and I'm pretty sure IDR_CLOSE_DIALOG
> would be fine visually.
> 
> The other concern I'd have is that this UI is a component Chrome App with a
> custom frame, rather than a standard dialog box. If someone changed the dialog
> frame, it might not be obvious to them that they should make sure the Identity
> API component app still looks right. However, on searching I did find some
other
> web UI's that use the same images, so maybe it's safer than I thought.
> 
> If you think that's the right way to go, I can drop this CL.

I do. Generally we want the UI to look consistent across chrome, and this is one
way of enforcing that.