Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 14122021: Revert 195328 "Use --internal-diff on svn 1.7+ to slightly reduc..." (Closed)

Created:
7 years, 8 months ago by jam
Modified:
7 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 195328 "Use --internal-diff on svn 1.7+ to slightly reduc..." Reverting r195363, r195328 and r195308. gcl upload is hanging for me unless I revert these changes. f:\src\chrome3\src>gcl upload o0m7 at this point, there's no output. If I press enter, I get: Got an exception Command svn diff --config-dir c:\users\jabdel~1\appdata\local\temp\tmp7dwbyp -r 195324:head svn://chrome-svn/chrome/trun k/src/webkit/glue/dom_operations_unittest.cc returned non-zero exit status 1 in f:\src\chrome3\src Authentication realm: <svn://chrome-svn:3690> 0039d316-1c4b-4281-b951-d872f2087c98 Password for 'jabdelmalek': Authentication realm: <svn://chrome-svn:3690> 0039d316-1c4b-4281-b951-d872f2087c98 > Use --internal-diff on svn 1.7+ to slightly reduce disk thrashing. > > This just saves the need to create and remove an empty directory on every call to GenerateDiff. > > Review URL: https://chromiumcodereview.appspot.com/14064017 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -81 lines) Patch
M trunk/tools/depot_tools/scm.py View 1 chunk +71 lines, -81 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jam
7 years, 8 months ago (2013-04-21 18:28:04 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698