Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14122017: [VS Addin] Add visual studio 2012 support (Closed)

Created:
7 years, 8 months ago by Sam Clegg
Modified:
7 years, 6 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[VS Addin] Add visual studio 2012 support Basic support for running and debugging of nacl and ppapi module is working. The two major problem are the lack of unit tests and the fact that nacl targets are always seen as dirty by VS2012 and will always completely rebuild. BUG=156648 TEST=test.bat (+ manual testing for 2012) R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1554

Patch Set 1 : #

Patch Set 2 : #

Total comments: 13

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : now with unit tests #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+614 lines, -457 lines) Patch
M .gitignore View 1 chunk +3 lines, -3 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/NaCl.Toolset.default.props View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/Microsoft.Cpp.NaCl64.props View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/Microsoft.Cpp.NaCl64.targets View 1 chunk +3 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/Microsoft.Cpp.NaCl64.default.props View 1 chunk +2 lines, -0 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/PlatformToolsets/v110/Microsoft.Cpp.NaCl64.v110.props View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/PlatformToolsets/v110/Microsoft.Cpp.NaCl64.v110.targets View 0 chunks +-1 lines, --1 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NativeClientVSAddIn.AddIn View 1 chunk +3 lines, -3 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/PNaCl/Microsoft.Cpp.PNaCl.targets View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/PNaCl/Props/pnacl_general.xml View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/PNaCl/Props/pnacl_general_ps.xml View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/Microsoft.Cpp.Win32.default.props.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/Microsoft.Cpp.Win32.props.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/Microsoft.Cpp.Win32.targets.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
D visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/Microsoft.Cpp.[platform].default.props.patch View 1 chunk +0 lines, -29 lines 0 comments Download
D visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/Microsoft.Cpp.[platform].props.patch View 1 chunk +0 lines, -20 lines 0 comments Download
D visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/Microsoft.Cpp.[platform].targets.patch View 1 chunk +0 lines, -63 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/PlatformToolsets/v100/Microsoft.Cpp.Win32.v100.props.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/PlatformToolsets/v100/Microsoft.Cpp.Win32.v100.targets.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
D visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/PlatformToolsets/v100/microsoft.cpp.[platform].v100.props.patch View 1 chunk +0 lines, -31 lines 0 comments Download
D visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/PlatformToolsets/v100/microsoft.cpp.[platform].v100.targets.patch View 1 chunk +0 lines, -14 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/V110/Microsoft.Cpp.Win32.default.props.patch View 2 chunks +2 lines, -13 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/V110/Microsoft.Cpp.Win32.targets.patch View 1 3 4 1 chunk +1 line, -0 lines 0 comments Download
A visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/V110/PlatformToolsets/v110/Microsoft.Cpp.Win32.v110.props.patch View 1 chunk +43 lines, -0 lines 0 comments Download
A visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/V110/PlatformToolsets/v110/Microsoft.Cpp.Win32.v110.targets.patch View 1 chunk +14 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py View 1 2 6 chunks +96 lines, -39 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/install.py View 7 chunks +174 lines, -113 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/xml_patch.py View 1 chunk +1 line, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/AssemblyInfo.cs View 1 chunk +2 lines, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/NativeClientVSAddIn.csproj View 2 chunks +2 lines, -2 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/NativeClientVSAddIn_2012.sln View 1 chunk +2 lines, -2 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/NativeClientVSAddIn_2012/NativeClientVSAddIn_2012.csproj View 5 chunks +53 lines, -31 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution2012/BlankValidSolution.sln View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution2012/NaClProject/NaClProject.vcxproj View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
A visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution2012/NaClProject/NaClProject.vcxproj.user View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution2012/NaClProject/index.html View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution2012/NaClProject/main.cpp View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution2012/NaClProject/multiprocess.props View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution2012/NaClProject/test_file.cpp View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution2012/NotNaCl/NotNaCl.csproj View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution2012/NotNaCl/Program.cs View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs View 1 2 3 4 1 chunk +1 line, -10 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/CompileParallelTest.cs View 2 chunks +1 line, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs View 1 2 3 4 5 chunks +17 lines, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs View 1 2 3 4 1 chunk +32 lines, -15 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs View 1 2 3 4 5 4 chunks +57 lines, -15 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/UnitTests.csproj View 2 chunks +2 lines, -2 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/UnitTests/UnitTests_2012.csproj View 1 2 3 4 4 chunks +14 lines, -16 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/build.bat View 1 chunk +5 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/buildbot_run.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/create_package.py View 1 2 7 chunks +52 lines, -32 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/test.bat View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/test_2012.bat View 1 2 3 4 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
binji
lgtm... the XML is still making me very confused, though. :) https://codereview.chromium.org/14122017/diff/7001/visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py File visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py (right): ...
7 years, 7 months ago (2013-05-25 00:02:55 UTC) #1
Sam Clegg
https://codereview.chromium.org/14122017/diff/7001/visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py File visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py (right): https://codereview.chromium.org/14122017/diff/7001/visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py#newcode181 visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py:181: raise Error('Win32 MSBuild folder not found: %s' % win32_dir) ...
7 years, 6 months ago (2013-05-29 04:58:33 UTC) #2
Sam Clegg
Now with unit tests. I had to disable 3 tests under 2012 initially but I ...
7 years, 6 months ago (2013-06-03 19:10:01 UTC) #3
Sam Clegg
ping
7 years, 6 months ago (2013-06-07 01:08:54 UTC) #4
binji
lgtm https://codereview.chromium.org/14122017/diff/23001/visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs File visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs (right): https://codereview.chromium.org/14122017/diff/23001/visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs#newcode124 visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs:124: #if VS2012 can only be determined at compile ...
7 years, 6 months ago (2013-06-07 18:49:19 UTC) #5
Sam Clegg
https://codereview.chromium.org/14122017/diff/23001/visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs File visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs (right): https://codereview.chromium.org/14122017/diff/23001/visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs#newcode124 visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs:124: #if VS2012 On 2013/06/07 18:49:19, binji wrote: > can ...
7 years, 6 months ago (2013-06-10 22:38:11 UTC) #6
Sam Clegg
https://codereview.chromium.org/14122017/diff/23001/visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs File visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs (right): https://codereview.chromium.org/14122017/diff/23001/visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs#newcode134 visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs:134: //if (IsVS2012()) On 2013/06/07 18:49:19, binji wrote: > unused? ...
7 years, 6 months ago (2013-06-11 18:53:58 UTC) #7
Sam Clegg
7 years, 6 months ago (2013-06-11 19:12:40 UTC) #8
Message was sent while issue was closed. 
Committed patchset #6 manually as r1554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698