Issue 14122013: [Android] Add recommended.gypi with recommended settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14122013: [Android] Add recommended.gypi with recommended settings (Closed)

Created:
7 years, 8 months ago by cjhopman

Modified:
7 years, 8 months ago

Reviewers:
Yaron

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Add recommended.gypi with recommended settings This gypi includes the recommended gyp settings for Chrome for Android development, as well as instructions for using the settings. NOTRY=true BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194219

Patch Set 1 #

Patch Set 2 : Fix copyright header #

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	A	build/android/developer_recommended_flags.gypi	View	1 2	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm but I want to paint the shed a different colour. "recommended" is too vague. ...

7 years, 8 months ago (2013-04-15 19:49:35 UTC) #2

cjhopman

7 years, 8 months ago (2013-04-15 20:13:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r194219 (presubmit successful).

Expand Messages | Collapse Messages