Use rep_movsb for copying one-byte strings in substring intrinsic.

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 1557 matching lines @@
 
 
 // Arg0: Onebyte String
 // Arg1: Start index as Smi.
 // Arg2: End index as Smi.
 // The indexes must be valid.
 bool Intrinsifier::OneByteString_substringUnchecked(Assembler* assembler) {
   const intptr_t kStringOffset = 3 * kWordSize;
   const intptr_t kStartIndexOffset = 2 * kWordSize;
   const intptr_t kEndIndexOffset = 1 * kWordSize;
-  Label fall_through, done;
+  Label fall_through;
   TryAllocateOnebyteString(
       assembler, &fall_through, kStartIndexOffset, kEndIndexOffset);
   // EAX: new string as tagged pointer.
   // Copy string.
   __ movl(EDI, Address(ESP, + kStringOffset));
   __ movl(EBX, Address(ESP, + kStartIndexOffset));
   __ SmiUntag(EBX);
   __ leal(EDI, FieldAddress(EDI, EBX, TIMES_1, OneByteString::data_offset()));
   // EDI: Start address to copy from (untagged).
-  __ movl(EDX, Address(ESP, + kEndIndexOffset));
-  __ SmiUntag(EDX);
-  __ subl(EDX, EBX);
-  __ xorl(ECX, ECX);
-  // EDX: Number of bytes to copy.
-  // ECX: Loop counter.
-  // TODO(srdjan): For large substrings it could be better if we would group
-  // the byte copies into word copies or even call memcpy.
-  Label loop, check;
-  // TODO(srdjan): Use rep movsb instead.
-  __ jmp(&check, Assembler::kNearJump);
-  __ Bind(&loop);
-  __ movzxb(EBX, Address(EDI, ECX, TIMES_1, 0));
-  __ movb(FieldAddress(EAX, ECX, TIMES_1, OneByteString::data_offset()), BL);
-  __ incl(ECX);
-  __ Bind(&check);
-  __ cmpl(ECX, EDX);
-  __ j(LESS, &loop, Assembler::kNearJump);
+  // EBX: Untagged start index.
+  __ movl(ECX, Address(ESP, + kEndIndexOffset));
+  __ SmiUntag(ECX);
+  __ subl(ECX, EBX);
+  // ECX: Untagged number of bytes to copy.
+  ASSERT(CTX == ESI);
+  __ pushl(ESI);  // Preserve CTX.
+  __ movl(ESI, EDI);  // from.
+  __ leal(EDI, FieldAddress(EAX, OneByteString::data_offset()));  // to.
+  __ rep_movsb();
+  __ popl(ESI);  // Restore CTX.
 
-  __ Bind(&done);
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32