Handle HTTP 200 responses received in response to byte range requests issued...

Handle HTTP 200 responses received in response to byte range requests issued by the plugin. This means that the server does not support byte range requests. Firefox handles this by destroying the current plugin instance and creating a new instance to handle the response. The stream which is created to pass the data off to the plugin is not seekable.Fix is to emulate Firefox behavior. Will work on unit testing the NPN_RequestRead related code in a separate CB. This fixes http://code.google.com/p/chromium/issues/detail?id=5403

Bug=5403
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7139

[jam, 2008-12-16 02:38:56]

http://codereview.chromium.org/14122/diff/37/230
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/14122/diff/37/230#newcode1403
Line 1403: char** values = new char*[values_vector.size() + 1];
no need to have this function (&DeleteArray), see how things are done without
extra allocation in WebPluginDelegateStub::OnInit, since we know that the
underlying strings aren't going away..

http://codereview.chromium.org/14122/diff/37/223
File webkit/glue/webplugin_impl.h (right):

http://codereview.chromium.org/14122/diff/37/223#newcode240
Line 240: WebCore::ResourceHandle* response_handle_to_ignore);
nit: should be 4 spaces

http://codereview.chromium.org/14122/diff/37/223#newcode312
Line 312: std::vector<std::string>* value_vector);
nit:spacing is off

http://codereview.chromium.org/14122/diff/37/223#newcode359
Line 359: int arg_count_;
why is this needed?  the vector lengths from below is enough

[ananta, 2008-12-16 17:56:17]

On 2008/12/16 02:38:56, John Abd-El-Malek wrote:
> http://codereview.chromium.org/14122/diff/37/230
> File webkit/glue/webplugin_impl.cc (right):
> 
> http://codereview.chromium.org/14122/diff/37/230#newcode1403
> Line 1403: char** values = new char*[values_vector.size() + 1];
> no need to have this function (&DeleteArray), see how things are done without
> extra allocation in WebPluginDelegateStub::OnInit, since we know that the
> underlying strings aren't going away..
> 
Done

> http://codereview.chromium.org/14122/diff/37/223
> File webkit/glue/webplugin_impl.h (right):
> 
> http://codereview.chromium.org/14122/diff/37/223#newcode240
> Line 240: WebCore::ResourceHandle* response_handle_to_ignore);
> nit: should be 4 spaces
> 
Fixed

> http://codereview.chromium.org/14122/diff/37/223#newcode312
> Line 312: std::vector<std::string>* value_vector);
> nit:spacing is off
Fixed

> 
> http://codereview.chromium.org/14122/diff/37/223#newcode359
> Line 359: int arg_count_;
> why is this needed?  the vector lengths from below is enough
Done

[jam, 2008-12-17 03:08:03]

lgtm

http://codereview.chromium.org/14122/diff/237/62
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/14122/diff/237/62#newcode1401
Line 1401: char** WebPluginImpl::VectorToArray(
perhaps there's no need for this function, it can be done inline just as how
WebPluginDelegateStub does it?