Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1412193010: Merge to XFA: (Reland) Switch builds to clang by default for Linux and OS X. (Closed)

Created:
5 years, 2 months ago by Oliver Chang
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: (Reland) Switch builds to clang by default for Linux and OS X. Also adds support for ASan and sanitizer coverage. BUG=pdfium:1, pdfium:171 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5478df43a8970257e9644ae6f57a6fe7513029c6 Review URL: https://codereview.chromium.org/1406843002 . (cherry picked from commit 3b2ab45f0a883046a7c457e8435b5a9b2c1c4156) Committed: https://pdfium.googlesource.com/pdfium/+/afaa98eeb161d60e76506a16d8b986203a7ec0b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M .gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
M DEPS View 2 chunks +9 lines, -0 lines 0 comments Download
M build/standalone.gypi View 5 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Oliver Chang
5 years, 2 months ago (2015-10-21 22:24:35 UTC) #1
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-21 22:29:29 UTC) #2
Oliver Chang
5 years, 2 months ago (2015-10-21 22:29:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
afaa98eeb161d60e76506a16d8b986203a7ec0b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698