Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412183009: EDK: Stop having MojoCreateDataPipeOptions as a member of DataPipe. (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Stop having MojoCreateDataPipeOptions as a member of DataPipe. The former is aligned whereas the latter isn't (except as forced by having the former as a member), which made it at least a bit dubious. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f0158ed2dbd0ec955384213a23f5816aa755472b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M mojo/edk/system/data_pipe.h View 3 chunks +9 lines, -11 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
viettrungluu
5 years, 1 month ago (2015-11-10 22:12:32 UTC) #1
viettrungluu
5 years, 1 month ago (2015-11-11 00:53:21 UTC) #4
jamesr
lgtm
5 years, 1 month ago (2015-11-11 01:05:47 UTC) #5
viettrungluu
5 years, 1 month ago (2015-11-11 01:13:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f0158ed2dbd0ec955384213a23f5816aa755472b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698