Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1412183008: Redo TimelineTask API (Closed)

Created:
5 years, 1 month ago by Cutch
Modified:
5 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Redo TimelineTask API A TimelineTask represents an asynchronous track of operations on the timeline. The old API allowed multiple isolates to emit events simultaneously on the same task or to start / finish events in any order. This isn't supported by our UI and probably many other tools that consume trace-event. With this change, operations within a TimelineTask must complete in the reverse order of their start calls (aka a stack). You can pass a TimelineTask from one isolate to another but you must first complete all open operations before passing it. Example: var task = new TimelineTask(); task.start('Some phase'); await someFuture; task.finish(); Also: Add support for instant events. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/291befa1cdb6c141fc24a0edaa048c41d69ada72

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -67 lines) Patch
M runtime/lib/timeline.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download
M runtime/lib/timeline.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart View 1 2 3 1 chunk +21 lines, -3 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/developer_patch.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/developer/timeline.dart View 1 2 6 chunks +92 lines, -64 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
5 years, 1 month ago (2015-11-10 20:32:52 UTC) #3
Cutch
PTAL
5 years, 1 month ago (2015-11-11 18:11:15 UTC) #5
rmacnak
lgtm
5 years, 1 month ago (2015-11-11 18:23:09 UTC) #6
Cutch
5 years, 1 month ago (2015-11-11 18:59:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
291befa1cdb6c141fc24a0edaa048c41d69ada72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698