scripts/slave/recipes/chromium_mojo.expected/full_chromium_mojo_Chromium_Mojo_Android.json - Issue 1412173008: Add simple build archiving for Mandoline binaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_mojo.expected/full_chromium_mojo_Chromium_Mojo_Android.json

Issue 1412173008: Add simple build archiving for Mandoline binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Use api.file.read and exec() instead of execfile for test_data. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_mojo.py ('k') | scripts/slave/recipes/chromium_mojo.expected/full_chromium_mojo_Chromium_Mojo_Android_Nexus5_Perf.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_mojo.expected/full_chromium_mojo_Chromium_Mojo_Android.json

diff --git a/scripts/slave/recipes/chromium_mojo.expected/full_chromium_mojo_Chromium_Mojo_Android.json b/scripts/slave/recipes/chromium_mojo.expected/full_chromium_mojo_Chromium_Mojo_Android.json

index f4cc675de348abd6e758bbb5758797ca7a073055..b018b747b997897f8be2296ffb7f9e18988f4c7b 100644

--- a/scripts/slave/recipes/chromium_mojo.expected/full_chromium_mojo_Chromium_Mojo_Android.json

+++ b/scripts/slave/recipes/chromium_mojo.expected/full_chromium_mojo_Chromium_Mojo_Android.json

@@ -670,27 +670,15 @@

]

{

- "cmd": [],

- "cwd": "[SLAVE_BUILD]",

- "name": "upload_mandoline"

- },

- {

"cmd": [

"python",

"-u",

- "RECIPE_MODULE[gsutil]/resources/gsutil_wrapper.py",

- "--",

- "[DEPOT_TOOLS]/gsutil.py",

- "----",

- "cp",

- "[SLAVE_BUILD]/src/out/Release/apks/Mandoline.apk",

- "gs://mandoline/37.0.2021.0/android/Mandoline.apk"

+ "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

+ "[SLAVE_BUILD]/src/mandoline/tools/data/FILES.cfg",

+ "/path/to/tmp/"

"cwd": "[SLAVE_BUILD]",

- "name": "gsutil upload",

- "~followup_annotations": [

- "@@@STEP_LINK@gsutil.upload@https://storage.cloud.google.com/mandoline/37.0.2021.0/android/Mandoline.apk@@@"

- ]

+ "name": "read FILES.cfg"

{

"name": "$result",