Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1412153003: PPC: [runtime] Implement %_ToLength via ToLengthStub. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Implement %_ToLength via ToLengthStub. Port e678a0f9a961165ab43cd1a6080fcb11995b701a Original commit message: Use %_ToLength for TO_LENGTH, implemented via a ToLengthStub that supports a fast path for small integers. Everything else is still handled in the runtime. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4494 LOG=n Committed: https://crrev.com/8fafb2916c8ef046b8e841f2fa12b46a8ac8772a Cr-Commit-Position: refs/heads/master@{#31384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 2 months ago (2015-10-19 14:45:13 UTC) #1
michael_dawson
On 2015/10/19 14:45:13, mtbrandyberry wrote: lgtm
5 years, 2 months ago (2015-10-19 16:26:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412153003/1
5 years, 2 months ago (2015-10-19 16:28:17 UTC) #4
michael_dawson
On 2015/10/19 16:28:17, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 2 months ago (2015-10-19 16:55:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 17:00:36 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 17:01:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fafb2916c8ef046b8e841f2fa12b46a8ac8772a
Cr-Commit-Position: refs/heads/master@{#31384}

Powered by Google App Engine
This is Rietveld 408576698