Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1412153002: [fullcode] Make intrinsic-to-stub-call handling platform independent. (Closed)

Created:
5 years, 2 months ago by Jarin
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcode] Make intrinsic-to-stub-call handling platform independent. Committed: https://crrev.com/3791cf9854ecae6b4733cab7babddabe15251b24 Cr-Commit-Position: refs/heads/master@{#31372}

Patch Set 1 #

Patch Set 2 : EmitRegExpConstructResult #

Patch Set 3 : Comment tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -615 lines) Patch
M src/code-factory.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 3 chunks +0 lines, -78 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 3 chunks +0 lines, -78 lines 0 comments Download
M src/full-codegen/full-codegen.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 3 chunks +0 lines, -80 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 3 chunks +0 lines, -85 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 3 chunks +0 lines, -85 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 3 chunks +0 lines, -63 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 3 chunks +0 lines, -79 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 3 chunks +0 lines, -67 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
5 years, 2 months ago (2015-10-19 11:38:20 UTC) #3
Benedikt Meurer
Nice. LGTM.
5 years, 2 months ago (2015-10-19 11:47:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412153002/40001
5 years, 2 months ago (2015-10-19 11:48:21 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-19 11:59:28 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 11:59:50 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3791cf9854ecae6b4733cab7babddabe15251b24
Cr-Commit-Position: refs/heads/master@{#31372}

Powered by Google App Engine
This is Rietveld 408576698