Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 1412133004: Revert of WebRTC: Update lkgr to new bots + cover chromium.webrtc.fyi (Closed)

Created:
5 years, 1 month ago by kjellander_chromium
Modified:
5 years, 1 month ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Revert of WebRTC: Update lkgr to new bots + cover chromium.webrtc.fyi (patchset #2 id:20001 of https://codereview.chromium.org/1416773007/ ) Reason for revert: This doesn't work as long as the got_revision property for the builders in chromium.webrtc.fyi is a Chromium revision. Changing it to be the WebRTC revision is easy, but it will have the side-effect of breaking the perf dashboard data reporting which is based on it. Since fixing that problem is a larger problem, I'm reverting this for now. Original issue's description: > WebRTC: Update lkgr to new bots + cover chromium.webrtc.fyi > > These updates will make it possible for WebRTC to setup auto-rolling > of WebRTC in Chromium's DEPS file. > > BUG=433305 > > Committed: https://chromium.googlesource.com/infra/infra/+/9302eea8378f31c678fceedc3862ec040d6aa589 TBR=machenbach@chromium.org,estaab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=433305 Committed: https://chromium.googlesource.com/infra/infra/+/5a842563ca146b0d34b53da107c4abfd9744eeeb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -30 lines) Patch
M infra/services/lkgr_finder/config/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M infra/services/lkgr_finder/config/webrtc_cfg.pyl View 1 chunk +4 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander_chromium
Created Revert of WebRTC: Update lkgr to new bots + cover chromium.webrtc.fyi
5 years, 1 month ago (2015-11-02 11:50:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133004/1
5 years, 1 month ago (2015-11-02 11:50:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/5a842563ca146b0d34b53da107c4abfd9744eeeb
5 years, 1 month ago (2015-11-02 11:50:33 UTC) #3
Michael Achenbach
5 years, 1 month ago (2015-11-02 12:37:35 UTC) #4
Message was sent while issue was closed.
lgtm - yea - you could first make a change that reports got_cr_revision to the
dashboard instead and then you could do us both a favor and fix the todo in
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

Powered by Google App Engine
This is Rietveld 408576698