Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Issue 1412133002: [es6] stage sticky regexps and RegExp.prototype.flags. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] stage sticky regexps and RegExp.prototype.flags. R=littledan@chromium.org BUG=v8:4342 LOG=Y Committed: https://crrev.com/722719fe31fe7fd5bb50be6256b3581bb28a8169 Cr-Commit-Position: refs/heads/master@{#31390} Committed: https://crrev.com/0a7996882e073e0670972e6d2968db17d484fa09 Cr-Commit-Position: refs/heads/master@{#31479}

Patch Set 1 #

Patch Set 2 : unmove tests #

Patch Set 3 : update test262.status #

Patch Set 4 : update status file wrt issue 4504 #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M src/flag-definitions.h View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M test/test262/test262.status View 1 2 3 2 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 31 (12 generated)
Yang
5 years, 2 months ago (2015-10-19 08:42:35 UTC) #1
Dan Ehrenberg
I think we tend to move things from harmony to es6 when it ships, rather ...
5 years, 2 months ago (2015-10-19 09:22:07 UTC) #2
Yang
On 2015/10/19 09:22:07, Dan Ehrenberg wrote: > I think we tend to move things from ...
5 years, 2 months ago (2015-10-19 09:25:12 UTC) #3
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-19 09:39:13 UTC) #4
Dan Ehrenberg
On 2015/10/19 at 09:39:13, Dan Ehrenberg wrote: > lgtm By the way, you'll probably have ...
5 years, 2 months ago (2015-10-19 09:39:37 UTC) #5
Yang
On 2015/10/19 09:39:37, Dan Ehrenberg wrote: > On 2015/10/19 at 09:39:13, Dan Ehrenberg wrote: > ...
5 years, 2 months ago (2015-10-19 12:11:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/40001
5 years, 2 months ago (2015-10-20 04:19:22 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-20 04:45:08 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/722719fe31fe7fd5bb50be6256b3581bb28a8169 Cr-Commit-Position: refs/heads/master@{#31390}
5 years, 2 months ago (2015-10-20 04:45:22 UTC) #11
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1403283004/ by machenbach@chromium.org. ...
5 years, 2 months ago (2015-10-20 07:53:10 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/60001
5 years, 2 months ago (2015-10-21 06:43:28 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-21 07:04:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/60001
5 years, 2 months ago (2015-10-22 13:08:35 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/9902)
5 years, 2 months ago (2015-10-22 13:35:35 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/80001
5 years, 2 months ago (2015-10-22 13:39:02 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/9234)
5 years, 2 months ago (2015-10-22 13:39:45 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/80001
5 years, 2 months ago (2015-10-22 13:45:51 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-22 14:15:39 UTC) #30
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 14:16:05 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0a7996882e073e0670972e6d2968db17d484fa09
Cr-Commit-Position: refs/heads/master@{#31479}

Powered by Google App Engine
This is Rietveld 408576698