|
|
Created:
5 years, 2 months ago by Yang Modified:
5 years, 2 months ago Reviewers:
Dan Ehrenberg CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[es6] stage sticky regexps and RegExp.prototype.flags.
R=littledan@chromium.org
BUG=v8:4342
LOG=Y
Committed: https://crrev.com/722719fe31fe7fd5bb50be6256b3581bb28a8169
Cr-Commit-Position: refs/heads/master@{#31390}
Committed: https://crrev.com/0a7996882e073e0670972e6d2968db17d484fa09
Cr-Commit-Position: refs/heads/master@{#31479}
Patch Set 1 #Patch Set 2 : unmove tests #Patch Set 3 : update test262.status #Patch Set 4 : update status file wrt issue 4504 #Patch Set 5 : rebase #Messages
Total messages: 31 (12 generated)
I think we tend to move things from harmony to es6 when it ships, rather than when it's staged.
On 2015/10/19 09:22:07, Dan Ehrenberg wrote: > I think we tend to move things from harmony to es6 when it ships, rather than > when it's staged. reverted moving of the test.
lgtm
On 2015/10/19 at 09:39:13, Dan Ehrenberg wrote: > lgtm By the way, you'll probably have to change test262.status (the presubmit tests will catch it if so).
On 2015/10/19 09:39:37, Dan Ehrenberg wrote: > On 2015/10/19 at 09:39:13, Dan Ehrenberg wrote: > > lgtm > > By the way, you'll probably have to change test262.status (the presubmit tests > will catch it if so). Thanks. I updated the tests. Apparently there are still a bunch of failing tests left. Should I fix them first or land this and work on them afterwards?
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from littledan@chromium.org Link to the patchset: https://codereview.chromium.org/1412133002/#ps40001 (title: "update test262.status")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/722719fe31fe7fd5bb50be6256b3581bb28a8169 Cr-Commit-Position: refs/heads/master@{#31390}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1403283004/ by machenbach@chromium.org. The reason for reverting is: [sheriff] breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds....
Message was sent while issue was closed.
Description was changed from ========== [es6] stage sticky regexps and RegExp.prototype.flags. R=littledan@chromium.org BUG=v8:4342 LOG=Y Committed: https://crrev.com/722719fe31fe7fd5bb50be6256b3581bb28a8169 Cr-Commit-Position: refs/heads/master@{#31390} ========== to ========== [es6] stage sticky regexps and RegExp.prototype.flags. R=littledan@chromium.org BUG=v8:4342 LOG=Y Committed: https://crrev.com/722719fe31fe7fd5bb50be6256b3581bb28a8169 Cr-Commit-Position: refs/heads/master@{#31390} ==========
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from littledan@chromium.org Link to the patchset: https://codereview.chromium.org/1412133002/#ps60001 (title: "update status file wrt issue 4504")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/9902)
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from littledan@chromium.org Link to the patchset: https://codereview.chromium.org/1412133002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412133002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412133002/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/0a7996882e073e0670972e6d2968db17d484fa09 Cr-Commit-Position: refs/heads/master@{#31479} |