Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1412123009: [Turbofan] Fix perf regression (Closed)

Created:
5 years, 2 months ago by Mircea Trofin
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Fix perf regression introduced by per-range change. When the range ends just at the gap of a non-deferred block, the last instruction the range covers is in the predecessor. If that predecessor is a deferred block, before this CL, we would splinter the remainder of the range all the way to the end. That leads to inefficient codegen, because we still want a split inside the deferred block. Also, opportunistically added a trace before we splinter, for better diagnostics. BUG=chromium:546416 LOG=N Committed: https://crrev.com/32b6e085e74a8fcf94a01d20740fe4fdede07a86 Cr-Commit-Position: refs/heads/master@{#31529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/live-range-separator.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Mircea Trofin
5 years, 2 months ago (2015-10-23 05:40:18 UTC) #3
Benedikt Meurer
LGTM
5 years, 2 months ago (2015-10-23 09:14:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412123009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412123009/1
5 years, 2 months ago (2015-10-23 15:11:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7028)
5 years, 2 months ago (2015-10-23 15:13:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412123009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412123009/1
5 years, 2 months ago (2015-10-23 15:45:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 15:46:48 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/32b6e085e74a8fcf94a01d20740fe4fdede07a86 Cr-Commit-Position: refs/heads/master@{#31529}
5 years, 2 months ago (2015-10-23 15:47:26 UTC) #14
Michael Achenbach
5 years, 2 months ago (2015-10-23 17:39:55 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1412893007/ by machenbach@chromium.org.

The reason for reverting is: [sheriff] breaks benchmarks:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/....

Powered by Google App Engine
This is Rietveld 408576698