content/browser/frame_host/navigation_request.cc - Issue 1412113006: Prevent the destruction of WebContents in NavigationThrottle methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1412113006: Prevent the destruction of WebContents in NavigationThrottle methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_handle_impl_unittest.cc ('k') | content/browser/loader/navigation_resource_throttle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_request.cc

diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc

index 93d9887eed0109858c360b3ac98c8b1f21d3dc7d..129bd6c9f313e0a9666e0f36f1900b60884a4da2 100644

--- a/content/browser/frame_host/navigation_request.cc

+++ b/content/browser/frame_host/navigation_request.cc

@@ -285,7 +285,8 @@ void NavigationRequest::OnRequestStarted(base::TimeTicks timestamp) {

void NavigationRequest::OnStartChecksComplete(

NavigationThrottle::ThrottleCheckResult result) {

- CHECK(result != NavigationThrottle::DEFER);

+ CHECK(result != NavigationThrottle::DEFER &&

+ result != NavigationThrottle::DESTROYED);

// Abort the request if needed. This will destroy the NavigationRequest.

if (result == NavigationThrottle::CANCEL_AND_IGNORE) {

@@ -300,7 +301,8 @@ void NavigationRequest::OnStartChecksComplete(