Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Issue 1412113003: mojo_benchmark: improve recording the chart data for perf dashboard. (Closed)

Created:
5 years, 2 months ago by ppi
Modified:
5 years, 2 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

mojo_benchmark: improve recording the chart data for perf dashboard. This patch: - adds the neccessary metadata to `chart_data` being recorded - records individual `chart_data` for individual benchmarks (so that all measurements won't be tracked on one collective chart) - fixes an import error introduced in 64736fae560422778d97e5e747458e34697cd24e R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7615d79003f86ad1958e4a0c2d9a613d01a50569

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Etienne's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -23 lines) Patch
M mojo/devtools/common/devtoolslib/perf_dashboard.py View 2 chunks +11 lines, -3 lines 0 comments Download
M mojo/devtools/common/devtoolslib/perf_dashboard_unittest.py View 1 chunk +25 lines, -13 lines 0 comments Download
M mojo/devtools/common/mojo_benchmark View 1 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi Etienne, ptal.
5 years, 2 months ago (2015-10-23 08:54:59 UTC) #2
etiennej
https://codereview.chromium.org/1412113003/diff/1/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1412113003/diff/1/mojo/devtools/common/mojo_benchmark#newcode247 mojo/devtools/common/mojo_benchmark:247: script_args.chart_data_output_file.write(chart_data_recorder.get_json()) Do you want to add a newline at ...
5 years, 2 months ago (2015-10-23 10:02:13 UTC) #3
ppi
https://codereview.chromium.org/1412113003/diff/1/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1412113003/diff/1/mojo/devtools/common/mojo_benchmark#newcode247 mojo/devtools/common/mojo_benchmark:247: script_args.chart_data_output_file.write(chart_data_recorder.get_json()) On 2015/10/23 10:02:12, etiennej wrote: > Do you ...
5 years, 2 months ago (2015-10-23 10:59:13 UTC) #4
etiennej
Thanks, lgtm
5 years, 2 months ago (2015-10-23 11:00:07 UTC) #5
ppi
5 years, 2 months ago (2015-10-23 11:04:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7615d79003f86ad1958e4a0c2d9a613d01a50569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698