third_party/WebKit/LayoutTests/fast/css/round-up-all-line-width-less-than-1-greater-than-0.html - Issue 1412103005: Make sure line widths in the range of 0px and 1px are rounded up to 1px for visibility.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/round-up-all-line-width-less-than-1-greater-than-0.html

Issue 1412103005: Make sure line widths in the range of 0px and 1px are rounded up to 1px for visibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/interpolation/border-width-interpolation.html ('k') | third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4

	5 <body>

	6 </body>

	7

	8 <script>

	9 var values = [{actual:"0px", expected:"0px"}, {actual:"0.9px", expected:"1px"}, {actual:"1px", expected:"1px"}, {actual:"0.2px", expected:"1px"}, {actual:"0.9pt ", expected:"1px"}, {actual:"1pt", expected:"1px"}, {actual:"0.2pt", expected:"1 px"}, {actual:"1.9pt", expected:"2px"}, {actual:"1pt", expected:"1px"}, {actual: "1.2pt", expected:"1px"}, {actual:"2.1px", expected:"2px"}, {actual:"2.9px", exp ected:"2px"}];
	nainar 2015/10/29 03:59:40 actual -> input Each entry on a new line actual -> input Each entry on a new line
	10

	11 for (var value of values) {

	12 var div = document.createElement("div");

	13 div.style = "outline: solid " + value.actual + " red; margin-bottom: 20px; dis play: none;";

	14 document.body.appendChild(div);

	15 div.textContent = "Div with outline of " + value + " computes to " + getCompu tedStyle(div).outlineWidth;
	nainar 2015/10/29 03:59:40 remove text and display: none remove text and display: none
	16 }

	17

	18 test(function() {

	19 var targets = document.querySelectorAll("div");

	20 for (var i=0; i < targets.length; i++) {

	21 assert_equals(getComputedStyle(targets[i]).outlineWidth, values[i].expected) ;

	22 }

	23 }, "Test that chrome rounds up all borders/outlines when they are less than 1px but greater than 0px but floors all other borders.");

	24

	25 </script>

OLD	NEW