third_party/WebKit/LayoutTests/fast/css/round-up-all-line-width-less-than-1-greater-than-0.html - Issue 1412103005: Make sure line widths in the range of 0px and 1px are rounded up to 1px for visibility.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/round-up-all-line-width-less-than-1-greater-than-0.html

Issue 1412103005: Make sure line widths in the range of 0px and 1px are rounded up to 1px for visibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/interpolation/border-width-interpolation.html ('k') | third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png » ('j') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4

	5 <body>

	6 </body>

	7

	8 <script>

	9 var actualValues = ["0px", "0.9px", "1px", "0.2px", "0.9pt", "1pt", "0.2pt", "1. 9pt", "1pt", "1.2pt", "2.1px", "2.9px"]

	10 var expectedValues = ["0px", "1px", "1px", "1px", "1px", "1px", "1px", "2px", "1 px", "1px", "2px", "2px"]
	alancutter (OOO until 2018) 2015/10/27 04:10:32 I would make this a dictionary of input: expected I would make this a dictionary of input: expected pairs to make the association between values clearer and less error prone. nainar 2015/10/27 05:30:18 Done. Done.
	11

	12 for (var value of actualValues) {

	13 var div = document.createElement("div");

	14 div.style = "outline: solid " + value + " red; margin-bottom: 20px; display: n one;";

	15 document.body.appendChild(div);

	16 div.textContent = "Div with outline of " + value + " computes to " + getCompu tedStyle(div).outlineWidth;

	17 }

	18

	19 test(function() {

	20 var targets = document.querySelectorAll("div");

	21 for (var i=0; i < targets.length; i++) {

	22 assert_equals(getComputedStyle(targets[i]).outlineWidth, expectedValues[i]);

	23 }

	24 }, "Test that chrome rounds up all borders/outlines when they are less than 1px but greater than 0px but floors all other borders.");

	25

	26 </script>

OLD	NEW