Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1412093008: Fix regression: background artifact for origin glyphs of the '.security-property-unknown' persuasio… (Closed)

Created:
5 years, 1 month ago by mmccoy
Modified:
5 years, 1 month ago
Reviewers:
lgarron, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix regression: background artifact for origin glyphs of the '.security-property-unknown' persuasion. BUG=548973 Committed: https://crrev.com/d8379fad19308fbb17bc696ee176330be2c675db Cr-Commit-Position: refs/heads/master@{#357020}

Patch Set 1 #

Patch Set 2 : No background treatment for security-property-unknown origin sidebar items #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/security/sidebar.css View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mmccoy
Hi guys, PTAL? Thanks! -mm
5 years, 1 month ago (2015-10-29 16:28:04 UTC) #2
dgozman
lgtm
5 years, 1 month ago (2015-10-29 17:23:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412093008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412093008/20001
5 years, 1 month ago (2015-10-29 17:25:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/133215)
5 years, 1 month ago (2015-10-29 18:48:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412093008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412093008/20001
5 years, 1 month ago (2015-10-30 01:38:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 02:11:49 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 02:12:59 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8379fad19308fbb17bc696ee176330be2c675db
Cr-Commit-Position: refs/heads/master@{#357020}

Powered by Google App Engine
This is Rietveld 408576698