Merge to XFA: Support linearized loading

Merge to XFA: Support linearized loading

BUG=446715
R=thestig@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/1353093003 .

Conflicts:
	core/include/fpdfapi/fpdf_parser.h
	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
	samples/pdfium_test.cc
	testing/embedder_test.cpp
	testing/embedder_test.h

Committed: https://pdfium.googlesource.com/pdfium/+/df7f3663364fd4d6148d658c5bdb98ab2532fb8d

[jun_fang, 2015-11-10 03:34:42]

jun_fang@foxitsoftware.com changed reviewers:
+ jun_fang@foxitsoftware.com, kai_jing@foxitsoftware.com, thestig@chromium.org

[jun_fang, 2015-11-10 03:34:42]

Hi Tom and Lei,

Please review it.

[Lei Zhang, 2015-11-10 04:40:20]

lgtm with some minor changes.

BTW, you uploaded the CL from your @gmail.com account.

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2685: int
IsDocAvail(IFX_DownloadHints* pHints) override;
You lost a comment: // IPDF_DataAvail:

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2690: 
extra blank line

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp (right):

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp:35:
OpenDocument("testing/resources/feature_linearized_loading.pdf", true));
No need for testing/resources/ in the path now.

https://codereview.chromium.org/1412083010/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1412083010/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:435: 
nit: there's no white space here on master

[jun_fang, 2015-11-10 06:13:57]

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2685: int
IsDocAvail(IFX_DownloadHints* pHints) override;
On 2015/11/10 04:40:19, Lei Zhang wrote:
> You lost a comment: // IPDF_DataAvail:

This comment is useless.

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2690: 
On 2015/11/10 04:40:19, Lei Zhang wrote:
> extra blank line

Acknowledged.

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp (right):

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp:35:
OpenDocument("testing/resources/feature_linearized_loading.pdf", true));
On 2015/11/10 04:40:19, Lei Zhang wrote:
> No need for testing/resources/ in the path now.

Acknowledged.

https://codereview.chromium.org/1412083010/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1412083010/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:435: 
On 2015/11/10 04:40:19, Lei Zhang wrote:
> nit: there's no white space here on master

Acknowledged.

[Lei Zhang, 2015-11-10 06:38:04]

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1412083010/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2685: int
IsDocAvail(IFX_DownloadHints* pHints) override;
On 2015/11/10 06:13:57, jun_fang wrote:
> On 2015/11/10 04:40:19, Lei Zhang wrote:
> > You lost a comment: // IPDF_DataAvail:
> 
> This comment is useless. 

It's not useless. It indicates the next block of overridden methods are for
IPDF_DataAvail. It's more useful when a class inherits from multiple classes,
but we would like to have it for all blocks of overridden methods.

[Jun Fang, 2015-11-10 10:29:54]

Committed patchset #2 (id:20001) manually as
df7f3663364fd4d6148d658c5bdb98ab2532fb8d (presubmit successful).

[Lei Zhang, 2015-11-10 10:41:02]

https://codereview.chromium.org/1412083010/diff/20001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1412083010/diff/20001/samples/pdfium_test.cc#...
samples/pdfium_test.cc:342: return FALSE;
Looks like you need to merge 71fca3fffc40f63b28c0085add17ac73b5a066ef next.

[Jun Fang, 2015-11-10 11:07:43]

On 2015/11/10 10:41:02, Lei Zhang wrote:
> https://codereview.chromium.org/1412083010/diff/20001/samples/pdfium_test.cc
> File samples/pdfium_test.cc (right):
> 
>
https://codereview.chromium.org/1412083010/diff/20001/samples/pdfium_test.cc#...
> samples/pdfium_test.cc:342: return FALSE;
> Looks like you need to merge 71fca3fffc40f63b28c0085add17ac73b5a066ef next.

Yes. I did it.