Add null checks for mNativeRemoteMediaPlayer

Add null checks for mNativeRemoteMediaPlayer

The null check in release() (which fixes the bug) became necessary
because of the recent refactoring. Although the current C++ code
should mean that some of the other members don't need null checks
this could change in future, so it seems sensible to put them in
throughout.

BUG=544717
Committed: https://crrev.com/3f082c0c58857aa2546c0b5fbbba68066ff76e91
Cr-Commit-Position: refs/heads/master@{#355033}

[aberent, 2015-10-19 18:43:53]

aberent@chromium.org changed reviewers:
+ dgn@chromium.org

[dgn, 2015-10-19 19:08:23]

https://codereview.chromium.org/1412083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java
(right):

https://codereview.chromium.org/1412083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java:279:
if (mRouteController != null) mRouteController.setMediaStateListener(null);
There are some other unprotected usages of the variable in the class. If it's
completely safe, would you mind specifying somewhere what are the cases in which
the controller is always supposed to be present? If it isn't, I think those
other cases should be guarded too.
Anyway, a comment on the variable explaining that it can be null any time would
be useful

[aberent, 2015-10-20 09:58:49]

Description was changed from

==========
Add null check to release

This became necessary because of the recent refactoring. Will probably
go away in the next refactoring step, but it is simple enough to
be worth fixing anyway.

BUG=544717
==========

to

==========
Add null checks for mNativeRemoteMediaPlayer

The null check in release() (which fixes the bug) became necessary 
because of the recent refactoring. Although the current C++ code
should mean that some of the other members don't need null checks
this could change in future, so it seems sensible to put them in
throughout.

BUG=544717
==========

[aberent, 2015-10-20 10:01:49]

PTAL

https://codereview.chromium.org/1412083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java
(right):

https://codereview.chromium.org/1412083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java:279:
if (mRouteController != null) mRouteController.setMediaStateListener(null);
On 2015/10/19 19:08:22, dgn wrote:
> There are some other unprotected usages of the variable in the class. If it's
> completely safe, would you mind specifying somewhere what are the cases in
which
> the controller is always supposed to be present? If it isn't, I think those
> other cases should be guarded too.
> Anyway, a comment on the variable explaining that it can be null any time
would
> be useful 

Added null checks throughout.

[dgn, 2015-10-20 10:19:05]

On 2015/10/20 10:01:49, aberent wrote:
> PTAL
> 
>
https://codereview.chromium.org/1412083003/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java
> (right):
> 
>
https://codereview.chromium.org/1412083003/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java:279:
> if (mRouteController != null) mRouteController.setMediaStateListener(null);
> On 2015/10/19 19:08:22, dgn wrote:
> > There are some other unprotected usages of the variable in the class. If
it's
> > completely safe, would you mind specifying somewhere what are the cases in
> which
> > the controller is always supposed to be present? If it isn't, I think those
> > other cases should be guarded too.
> > Anyway, a comment on the variable explaining that it can be null any time
> would
> > be useful 
> 
> Added null checks throughout.

lgtm

[aberent, 2015-10-20 10:19:58]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2015-10-20 10:20:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412083003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412083003/20001

[commit-bot: I haz the power, 2015-10-20 11:06:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-20 11:07:44]

Patchset 2 (id:??) landed as
https://crrev.com/3f082c0c58857aa2546c0b5fbbba68066ff76e91
Cr-Commit-Position: refs/heads/master@{#355033}