chrome/browser/ui/cocoa/browser_window_cocoa.h - Issue 1412083002: Indicate in the Window menu which Chrome window has an active sound playing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 1412083002: Indicate in the Window menu which Chrome window has an active sound playing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modified based on the code reviews Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_window.h ('K') | « chrome/browser/ui/browser_window.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.h

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.h b/chrome/browser/ui/cocoa/browser_window_cocoa.h

index 637edc505c961ce0cdf4016a5cb27b8125130608..3bb9c35462e7e326d1ebb18d878bd359cfdd0f4e 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.h

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.h

@@ -180,6 +180,8 @@ class BrowserWindowCocoa

// Returns the cocoa-world BrowserWindowController

BrowserWindowController* cocoa_controller() { return controller_; }

+ void UpdateMediaState(TabMediaState media_state);

Robert Sesek 2015/10/23 14:26:37 Copy the comment that was lost.

protected:

void DestroyBrowser() override;

@@ -191,6 +193,8 @@ class BrowserWindowCocoa

base::scoped_nsobject<NSString> pending_window_title_;

ui::WindowShowState initial_show_state_;

NSInteger attention_request_id_; // identifier from requestUserAttention

+ TabMediaState media_state_;

Robert Sesek 2015/10/23 14:26:37 This should also have a comment.

};

#endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_